Properly throw java exceptions from shouldOverrideUrlLoading

base/test/android/test_system_message_handler_link_android.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_TEST_SYSTEM_MESSAGE_HANDLER_LINK_ANDROID_H
+#define BASE_TEST_SYSTEM_MESSAGE_HANDLER_LINK_ANDROID_H
+
+#include <jni.h>
+
+#include "base/android/scoped_java_ref.h"
+#include "base/message_loop/message_pump.h"
+
+namespace base {
+
+class MessagePumpForUI;
+class WaitableEvent;
+
+namespace android {
+class TestJavaMessageHandlerFactory;
+
+/**
+ * This provides a link to (a way to create) the java-side

[nyquist, 2016/08/18 15:50:03]

Nit: This should use // style comments

[gsennton, 2016/08/18 18:56:55]

Done.

+ * TestSystemMessageHandler class.
+ */
+class TestSystemMessageHandlerLink {
+ public:
+  static bool RegisterJNI(JNIEnv* env);
+
+ private:
+  friend class base::android::TestJavaMessageHandlerFactory;
+
+  TestSystemMessageHandlerLink() = delete;
+  ~TestSystemMessageHandlerLink() = delete;
+
+  static base::android::ScopedJavaLocalRef<jobject>
+  createTestSystemMessageHandler(JNIEnv* env,

[nyquist, 2016/08/18 15:50:03]

Nit: CreateTestSystemMessageHandler

[gsennton, 2016/08/18 18:56:55]

Done.

+                                 base::MessagePump::Delegate* delegate,
+                                 MessagePumpForUI* message_pump,
+                                 WaitableEvent* test_done_event);
+};
+
+}  // namespace android
+}  // namespace base
+
+#endif  // BASE_TEST_SYSTEM_MESSAGE_HANDLER_LINK_ANDROID_H