base/run_all_base_unittests.cc - Issue 2169553002: Properly throw java exceptions from shouldOverrideUrlLoading

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/run_all_base_unittests.cc

Issue 2169553002: Properly throw java exceptions from shouldOverrideUrlLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unused includes in test_support_android.cc. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« base/message_loop/message_pump_android.h ('K') | « base/message_loop/message_pump_android.cc ('k') | base/test/BUILD.gn » ('j') | base/test/android/java/src/org/chromium/base/TestSystemMessageHandler.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
	nyquist 2016/08/18 15:50:02 Nit: No (c) here or in any other added file. Nit: No (c) here or in any other added file. gsennton 2016/08/18 18:56:54 Done. Show quoted text On 2016/08/18 15:50:02, nyquist wrote: > Nit: No (c) here or in any other added file. Done.
2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/bind.h"	5 #include "base/bind.h"

6 #include "base/test/launcher/unit_test_launcher.h"	6 #include "base/test/launcher/unit_test_launcher.h"

7 #include "base/test/test_suite.h"	7 #include "base/test/test_suite.h"

8 #include "build/build_config.h"	8 #include "build/build_config.h"

9 #include "mojo/edk/embedder/embedder.h"	9

	10 #if defined(OS_ANDROID)
	danakj 2016/08/18 17:50:16 And plz move this file to base/test/ also And plz move this file to base/test/ also gsennton 2016/08/18 18:56:54 Done. Show quoted text On 2016/08/18 17:50:16, danakj wrote: > And plz move this file to base/test/ also Done.
	11 #include "base/android/jni_android.h"

	12 #include "base/test/android/test_system_message_handler_link_android.h"

	13 #endif // defined(OS_ANDROID)

10	14

11 int main(int argc, char** argv) {	15 int main(int argc, char** argv) {

12 mojo::edk::Init();	16 #if defined(OS_ANDROID)

	17 base::android::TestSystemMessageHandlerLink::RegisterJNI(

	18 base::android::AttachCurrentThread());

	19 #endif // defined(OS_ANDROID)

	20

13 base::TestSuite test_suite(argc, argv);	21 base::TestSuite test_suite(argc, argv);

14 return base::LaunchUnitTests(	22 return base::LaunchUnitTests(

15 argc, argv,	23 argc, argv,

16 base::Bind(&base::TestSuite::Run, base::Unretained(&test_suite)));	24 base::Bind(&base::TestSuite::Run, base::Unretained(&test_suite)));

17 }	25 }

OLD	NEW