Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: tools/viewer/sk_app/mac/Window_mac.cpp

Issue 2169543002: Use Windowing system-specific WindowContext factories. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: more xlib Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/viewer/sk_app/mac/Window_mac.h ('k') | tools/viewer/sk_app/unix/GLWindowContext_unix.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/viewer/sk_app/mac/Window_mac.cpp
diff --git a/tools/viewer/sk_app/mac/Window_mac.cpp b/tools/viewer/sk_app/mac/Window_mac.cpp
index fdc6f80bd69fa93d954774de083e1f8f247d333d..b1ab5c9fe78f186e57c6c803657a782fc2faa402 100644
--- a/tools/viewer/sk_app/mac/Window_mac.cpp
+++ b/tools/viewer/sk_app/mac/Window_mac.cpp
@@ -9,7 +9,7 @@
#include "SkUtils.h"
#include "Timer.h"
-#include "../GLWindowContext.h"
+#include "WindowContextFactory_mac.h"
#include "Window_mac.h"
namespace sk_app {
@@ -270,19 +270,20 @@ void Window_mac::show() {
bool Window_mac::attach(BackendType attachType, const DisplayParams& params) {
this->initWindow(fDisplay, &params);
- ContextPlatformData_mac platformData;
- platformData.fDisplay = fDisplay;
- platformData.fWindow = fWindow;
- platformData.fVisualInfo = fVisualInfo;
+ MacWindowInfo info;
+#if 0
+ // Init Mac window info here
+ info.foo = foo;
+#endif
switch (attachType) {
#ifdef SK_VULKAN
case kVulkan_BackendType:
- fWindowContext = VulkanWindowContext::Create((void*)&platformData, params);
+ fWindowContext = NewVulkanForMac(info, params);
break;
#endif
case kNativeGL_BackendType:
default:
- fWindowContext = GLWindowContext::Create((void*)&platformData, params);
+ fWindowContext = NewGLForMac(info, params);
break;
}
« no previous file with comments | « tools/viewer/sk_app/mac/Window_mac.h ('k') | tools/viewer/sk_app/unix/GLWindowContext_unix.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698