ash/wm/window_cycle_controller_unittest.cc - Issue 2169533002: mash: Migrate shelf app list button to wm common types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/window_cycle_controller_unittest.cc

Issue 2169533002: mash: Migrate shelf app list button to wm common types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/wm/overview/window_selector_unittest.cc ('k') | chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/window_cycle_controller_unittest.cc

diff --git a/ash/wm/window_cycle_controller_unittest.cc b/ash/wm/window_cycle_controller_unittest.cc

index e1b1c5867f2364f199228e9378017944a36b25d2..21f02e37d20cfee4b5545a1d570c28d8446c7416 100644

--- a/ash/wm/window_cycle_controller_unittest.cc

+++ b/ash/wm/window_cycle_controller_unittest.cc

@@ -486,10 +486,10 @@ TEST_F(WindowCycleControllerTest, SelectingHidesAppList) {

std::unique_ptr<aura::Window> window0(CreateTestWindowInShellWithId(0));

std::unique_ptr<aura::Window> window1(CreateTestWindowInShellWithId(1));

- Shell::GetInstance()->ShowAppList(NULL);

- EXPECT_TRUE(Shell::GetInstance()->GetAppListTargetVisibility());

+ WmShell::Get()->ShowAppList();

+ EXPECT_TRUE(WmShell::Get()->GetAppListTargetVisibility());

controller->HandleCycleWindow(WindowCycleController::FORWARD);

- EXPECT_FALSE(Shell::GetInstance()->GetAppListTargetVisibility());

+ EXPECT_FALSE(WmShell::Get()->GetAppListTargetVisibility());

}

// Tests that cycling through windows shows and minimizes windows as they

« no previous file with comments | « ash/wm/overview/window_selector_unittest.cc ('k') | chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc » ('j') | no next file with comments »