Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2896)

Unified Diff: ash/accelerators/accelerator_controller_unittest.cc

Issue 2169533002: mash: Migrate shelf app list button to wm common types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/accelerators/accelerator_controller_delegate_aura.cc ('k') | ash/accelerators/accelerator_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/accelerators/accelerator_controller_unittest.cc
diff --git a/ash/accelerators/accelerator_controller_unittest.cc b/ash/accelerators/accelerator_controller_unittest.cc
index 452a4f79e2d495da8474072d79856faad6df10df..d9b8f3777b8a7f0b33b25a3e4ec7ed463fad4e18 100644
--- a/ash/accelerators/accelerator_controller_unittest.cc
+++ b/ash/accelerators/accelerator_controller_unittest.cc
@@ -954,18 +954,18 @@ TEST_F(AcceleratorControllerTest, GlobalAccelerators) {
TEST_F(AcceleratorControllerTest, GlobalAcceleratorsToggleAppList) {
AccessibilityDelegate* delegate = WmShell::Get()->accessibility_delegate();
- EXPECT_FALSE(Shell::GetInstance()->GetAppListTargetVisibility());
+ EXPECT_FALSE(WmShell::Get()->GetAppListTargetVisibility());
// The press event should not open the AppList, the release should instead.
EXPECT_FALSE(
ProcessInController(ui::Accelerator(ui::VKEY_LWIN, ui::EF_NONE)));
EXPECT_EQ(ui::VKEY_LWIN, GetCurrentAccelerator().key_code());
- EXPECT_FALSE(Shell::GetInstance()->GetAppListTargetVisibility());
+ EXPECT_FALSE(WmShell::Get()->GetAppListTargetVisibility());
EXPECT_TRUE(
ProcessInController(ReleaseAccelerator(ui::VKEY_LWIN, ui::EF_NONE)));
- EXPECT_TRUE(Shell::GetInstance()->GetAppListTargetVisibility());
+ EXPECT_TRUE(WmShell::Get()->GetAppListTargetVisibility());
EXPECT_EQ(ui::VKEY_LWIN, GetPreviousAccelerator().key_code());
@@ -976,13 +976,13 @@ TEST_F(AcceleratorControllerTest, GlobalAcceleratorsToggleAppList) {
EXPECT_FALSE(
ProcessInController(ReleaseAccelerator(ui::VKEY_LWIN, ui::EF_NONE)));
delegate->ToggleSpokenFeedback(A11Y_NOTIFICATION_NONE);
- EXPECT_TRUE(Shell::GetInstance()->GetAppListTargetVisibility());
+ EXPECT_TRUE(WmShell::Get()->GetAppListTargetVisibility());
EXPECT_FALSE(
ProcessInController(ui::Accelerator(ui::VKEY_LWIN, ui::EF_NONE)));
EXPECT_TRUE(
ProcessInController(ReleaseAccelerator(ui::VKEY_LWIN, ui::EF_NONE)));
- EXPECT_FALSE(Shell::GetInstance()->GetAppListTargetVisibility());
+ EXPECT_FALSE(WmShell::Get()->GetAppListTargetVisibility());
// When spoken feedback is on, the AppList should not toggle.
delegate->ToggleSpokenFeedback(A11Y_NOTIFICATION_NONE);
@@ -991,16 +991,16 @@ TEST_F(AcceleratorControllerTest, GlobalAcceleratorsToggleAppList) {
EXPECT_FALSE(
ProcessInController(ReleaseAccelerator(ui::VKEY_LWIN, ui::EF_NONE)));
delegate->ToggleSpokenFeedback(A11Y_NOTIFICATION_NONE);
- EXPECT_FALSE(Shell::GetInstance()->GetAppListTargetVisibility());
+ EXPECT_FALSE(WmShell::Get()->GetAppListTargetVisibility());
#if defined(OS_CHROMEOS)
// The press of VKEY_BROWSER_SEARCH should toggle the AppList
EXPECT_TRUE(ProcessInController(
ui::Accelerator(ui::VKEY_BROWSER_SEARCH, ui::EF_NONE)));
- EXPECT_TRUE(Shell::GetInstance()->GetAppListTargetVisibility());
+ EXPECT_TRUE(WmShell::Get()->GetAppListTargetVisibility());
EXPECT_FALSE(ProcessInController(
ReleaseAccelerator(ui::VKEY_BROWSER_SEARCH, ui::EF_NONE)));
- EXPECT_TRUE(Shell::GetInstance()->GetAppListTargetVisibility());
+ EXPECT_TRUE(WmShell::Get()->GetAppListTargetVisibility());
#endif
}
« no previous file with comments | « ash/accelerators/accelerator_controller_delegate_aura.cc ('k') | ash/accelerators/accelerator_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698