Add spinner, status text and Re-scan button to Bluetooth chooser on Mac

Add spinner, status text and Re-scan button to Bluetooth chooser on Mac

This is part 4 of matching WebBluetooth chooser views to mocks.

This CL adds:
1. a spinner that starts when the chooser scans for Bluetooth devices
and stops when the scan completes.
2. a status text:
"Scanning for devices..." when chooser is scanning for Bluetooth devices.
3. a Re-scan button which user can click it to re-scan Bluetooth devices.

The screenshots were uploaded on the issue page.

BUG=583452
Committed: https://crrev.com/b83e4b6357dbf1707eacd00e6612e1bd1c0021fa
Cr-Commit-Position: refs/heads/master@{#406987}

[juncai, 2016-07-20 18:51:33]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 18:52:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 19:41:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:41:19]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-07-20 19:45:27]

juncai@chromium.org changed reviewers:
+ rsesek@chromium.org

[juncai, 2016-07-20 19:45:27]

Please take a look.

[Robert Sesek, 2016-07-21 14:56:32]

lgtm

https://codereview.chromium.org/2169513004/diff/1/chrome/browser/ui/cocoa/cho...
File chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm (right):

https://codereview.chromium.org/2169513004/diff/1/chrome/browser/ui/cocoa/cho...
chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm:139: void
ChooserContentViewController::OnRefreshStateChanged(bool refreshing) {
Should there be unit tests for these methods?

[juncai, 2016-07-21 19:00:57]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 19:01:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:34:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:34:29]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[juncai, 2016-07-21 22:06:46]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 22:07:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-07-21 22:08:14]

https://codereview.chromium.org/2169513004/diff/1/chrome/browser/ui/cocoa/cho...
File chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm (right):

https://codereview.chromium.org/2169513004/diff/1/chrome/browser/ui/cocoa/cho...
chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm:139: void
ChooserContentViewController::OnRefreshStateChanged(bool refreshing) {
On 2016/07/21 14:56:32, Robert Sesek wrote:
> Should there be unit tests for these methods?

Yes. It needs to modify MockChooserController, I am working on a follow-up patch
to first add tests to non-Mac version, then add tests to Mac version.

[commit-bot: I haz the power, 2016-07-21 22:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 22:48:46]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-07-21 23:18:40]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-07-21 23:18:40]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2169513004/#ps40001
(title: "modified spinner size and align rescan text with buttons")

[commit-bot: I haz the power, 2016-07-21 23:19:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 23:23:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-21 23:26:15]

Description was changed from

==========
Add spinner, status text and Re-scan button to Bluetooth chooser on Mac

This is part 4 of matching WebBluetooth chooser views to mocks.

This CL adds:
1. a spinner that starts when the chooser scans for Bluetooth devices
and stops when the scan completes.
2. a status text:
"Scanning for devices..." when chooser is scanning for Bluetooth devices.
3. a Re-scan button which user can click it to re-scan Bluetooth devices.

The screenshots were uploaded on the issue page.

BUG=583452
==========

to

==========
Add spinner, status text and Re-scan button to Bluetooth chooser on Mac

This is part 4 of matching WebBluetooth chooser views to mocks.

This CL adds:
1. a spinner that starts when the chooser scans for Bluetooth devices
and stops when the scan completes.
2. a status text:
"Scanning for devices..." when chooser is scanning for Bluetooth devices.
3. a Re-scan button which user can click it to re-scan Bluetooth devices.

The screenshots were uploaded on the issue page.

BUG=583452

Committed: https://crrev.com/b83e4b6357dbf1707eacd00e6612e1bd1c0021fa
Cr-Commit-Position: refs/heads/master@{#406987}
==========

[commit-bot: I haz the power, 2016-07-21 23:26:16]

Patchset 3 (id:??) landed as
https://crrev.com/b83e4b6357dbf1707eacd00e6612e1bd1c0021fa
Cr-Commit-Position: refs/heads/master@{#406987}