components/exo/notification_surface.h - Issue 2169513003: exo: Add notification surface to manager after commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/exo/notification_surface.h

Issue 2169513003: exo: Add notification surface to manager after commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix nit, update dtor and only AddSurface when there are contents Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/exo/notification_surface.h

diff --git a/components/exo/notification_surface.h b/components/exo/notification_surface.h

index 683c380cfb7d8ed7a499410690b231e6a35dca31..33bfa2f0f4ce589db81d28abea5f18cecbfc9ec8 100644

--- a/components/exo/notification_surface.h

+++ b/components/exo/notification_surface.h

@@ -47,6 +47,7 @@ class NotificationSurface : public SurfaceDelegate, public SurfaceObserver {

const std::string notification_id_;

std::unique_ptr<aura::Window> window_;

+ bool added_to_manager_ = false;

DISALLOW_COPY_AND_ASSIGN(NotificationSurface);

};

« no previous file with comments | « no previous file | components/exo/notification_surface.cc » ('j') | no next file with comments »