Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2169503002: Remove flip_server. (Closed)

Created:
4 years, 5 months ago by Bence
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton, agrieve
CC:
chromium-reviews, cbentzel+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove flip_server. * Remove src/net/tools/flip_server/. * Remove //net:flip_in_mem_edsm_server, //net:flip_in_mem_edsm_server_base, //net:flip_in_mem_edsm_server_unittests. * Remove now unused BufferedSpdyFramer::CreateSynStream() and BufferedSpdyFramer::CreateSynReply() methods. BUG=629818 Committed: https://crrev.com/69866a47ebf38e14e330e15de944a695458c3141 Cr-Commit-Position: refs/heads/master@{#406822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7536 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M net/BUILD.gn View 2 chunks +0 lines, -82 lines 0 comments Download
M net/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M net/net.gyp View 2 chunks +0 lines, -84 lines 0 comments Download
M net/spdy/buffered_spdy_framer.h View 1 chunk +0 lines, -8 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M net/tools/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D net/tools/flip_server/acceptor_thread.h View 1 chunk +0 lines, -95 lines 0 comments Download
D net/tools/flip_server/acceptor_thread.cc View 1 chunk +0 lines, -206 lines 0 comments Download
D net/tools/flip_server/constants.h View 1 chunk +0 lines, -25 lines 0 comments Download
D net/tools/flip_server/flip_config.h View 1 chunk +0 lines, -97 lines 0 comments Download
D net/tools/flip_server/flip_config.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D net/tools/flip_server/flip_in_mem_edsm_server.cc View 1 chunk +0 lines, -403 lines 0 comments Download
D net/tools/flip_server/flip_test_utils.h View 1 chunk +0 lines, -58 lines 0 comments Download
D net/tools/flip_server/flip_test_utils.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D net/tools/flip_server/http_interface.h View 1 chunk +0 lines, -143 lines 0 comments Download
D net/tools/flip_server/http_interface.cc View 1 chunk +0 lines, -343 lines 0 comments Download
D net/tools/flip_server/http_interface_test.cc View 1 chunk +0 lines, -491 lines 0 comments Download
D net/tools/flip_server/mem_cache.h View 1 chunk +0 lines, -154 lines 0 comments Download
D net/tools/flip_server/mem_cache.cc View 1 chunk +0 lines, -238 lines 0 comments Download
D net/tools/flip_server/mem_cache_test.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D net/tools/flip_server/output_ordering.h View 1 chunk +0 lines, -91 lines 0 comments Download
D net/tools/flip_server/output_ordering.cc View 1 chunk +0 lines, -180 lines 0 comments Download
D net/tools/flip_server/ring_buffer.h View 1 chunk +0 lines, -113 lines 0 comments Download
D net/tools/flip_server/ring_buffer.cc View 1 chunk +0 lines, -241 lines 0 comments Download
D net/tools/flip_server/run_all_tests.cc View 1 chunk +0 lines, -8 lines 0 comments Download
D net/tools/flip_server/sm_connection.h View 1 chunk +0 lines, -163 lines 0 comments Download
D net/tools/flip_server/sm_connection.cc View 1 chunk +0 lines, -657 lines 0 comments Download
D net/tools/flip_server/sm_interface.h View 1 chunk +0 lines, -87 lines 0 comments Download
D net/tools/flip_server/spdy_interface.h View 1 chunk +0 lines, -221 lines 0 comments Download
D net/tools/flip_server/spdy_interface.cc View 1 chunk +0 lines, -571 lines 0 comments Download
D net/tools/flip_server/spdy_interface_test.cc View 1 chunk +0 lines, -512 lines 0 comments Download
D net/tools/flip_server/spdy_ssl.h View 1 chunk +0 lines, -30 lines 0 comments Download
D net/tools/flip_server/spdy_ssl.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D net/tools/flip_server/spdy_util.h View 1 chunk +0 lines, -22 lines 0 comments Download
D net/tools/flip_server/spdy_util.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D net/tools/flip_server/streamer_interface.h View 1 chunk +0 lines, -138 lines 0 comments Download
D net/tools/flip_server/streamer_interface.cc View 1 chunk +0 lines, -201 lines 0 comments Download
D net/tools/flip_server/tcp_socket_util.h View 1 chunk +0 lines, -54 lines 0 comments Download
D net/tools/flip_server/tcp_socket_util.cc View 1 chunk +0 lines, -276 lines 0 comments Download
D net/tools/flip_server/url_to_filename_encoder.h View 1 chunk +0 lines, -214 lines 0 comments Download
D net/tools/flip_server/url_to_filename_encoder.cc View 1 chunk +0 lines, -275 lines 0 comments Download
D net/tools/flip_server/url_to_filename_encoder_unittest.cc View 1 chunk +0 lines, -357 lines 0 comments Download
D net/tools/flip_server/url_utilities.h View 1 chunk +0 lines, -35 lines 0 comments Download
D net/tools/flip_server/url_utilities.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D net/tools/flip_server/url_utilities_unittest.cc View 1 chunk +0 lines, -98 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Bence
Ryan: PTAL at net/. Thank you.
4 years, 5 months ago (2016-07-20 16:32:46 UTC) #6
Ryan Hamilton
lgtm MAKE IT SO!!!!!
4 years, 5 months ago (2016-07-20 21:52:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169503002/1
4 years, 5 months ago (2016-07-20 21:53:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/221792)
4 years, 5 months ago (2016-07-20 22:04:16 UTC) #11
Bence
Andrew: PTAL at BUILD.gn and build/gn_migration.gypi. Thank you.
4 years, 5 months ago (2016-07-21 00:36:26 UTC) #13
agrieve
On 2016/07/21 00:36:26, Bence wrote: > Andrew: PTAL at BUILD.gn and build/gn_migration.gypi. Thank you. lgtm
4 years, 5 months ago (2016-07-21 01:53:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169503002/1
4 years, 5 months ago (2016-07-21 11:59:18 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 12:03:40 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 12:06:41 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69866a47ebf38e14e330e15de944a695458c3141
Cr-Commit-Position: refs/heads/master@{#406822}

Powered by Google App Engine
This is Rietveld 408576698