Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2169493002:
[Turbofan] Fix GapResolver tests. (Closed)
|
Created:
4 years, 5 months ago by bbudge Modified:
4 years, 5 months ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Turbofan] Fix GapResolver tests.
Fixes bug in test-gap-resolver.cc that didn't test different move reps.
Fixes test canonicalization so all slots have the same type (non-float).
Improve test failure text output.
LOG=N
BUG=v8:5187
Committed: https://crrev.com/8730875b2b64610b67f5a65164fd9b6914a2fd81
Cr-Commit-Position: refs/heads/master@{#37915}
Patch Set 1 #Patch Set 2 : Fix comments. #Patch Set 3 : Fix test-gap-resolver. #Patch Set 4 : Disable float32 on Arm. #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bbudge@chromium.org changed reviewers: + bmeurer@chromium.org
This was pretty badly broken. PTAL while trybots try.
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Turbofan] Fix InstructionOperand canonicalization. Modifies canonicalization to respect float stack slot type. Fixes bug in test-gap-resolver.cc that didn't test different move reps. LOG=N BUG=v8:5187 ========== to ========== [Turbofan] Fix GapResolver tests. Fixes bug in test-gap-resolver.cc that didn't test different move reps. Fixes test canonicalization so all slots have the same type (non-float). Improve test failure text output. LOG=N BUG=v8:5187 ==========
On 2016/07/20 14:52:03, bbudge wrote: > This was pretty badly broken. PTAL while trybots try. Turns out canonicalization is OK. The test was broken though.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bbudge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Turbofan] Fix GapResolver tests. Fixes bug in test-gap-resolver.cc that didn't test different move reps. Fixes test canonicalization so all slots have the same type (non-float). Improve test failure text output. LOG=N BUG=v8:5187 ========== to ========== [Turbofan] Fix GapResolver tests. Fixes bug in test-gap-resolver.cc that didn't test different move reps. Fixes test canonicalization so all slots have the same type (non-float). Improve test failure text output. LOG=N BUG=v8:5187 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== [Turbofan] Fix GapResolver tests. Fixes bug in test-gap-resolver.cc that didn't test different move reps. Fixes test canonicalization so all slots have the same type (non-float). Improve test failure text output. LOG=N BUG=v8:5187 ========== to ========== [Turbofan] Fix GapResolver tests. Fixes bug in test-gap-resolver.cc that didn't test different move reps. Fixes test canonicalization so all slots have the same type (non-float). Improve test failure text output. LOG=N BUG=v8:5187 Committed: https://crrev.com/8730875b2b64610b67f5a65164fd9b6914a2fd81 Cr-Commit-Position: refs/heads/master@{#37915} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/8730875b2b64610b67f5a65164fd9b6914a2fd81 Cr-Commit-Position: refs/heads/master@{#37915} |
