Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2169463003:
Add an experimental settings check into the getter for launchQRScanner. (Closed)
|
Created:
4 years, 5 months ago by sklencarova Modified:
4 years, 5 months ago CC:
chromium-reviews, sdefresne+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd an experimental settings check into the getter for launchQRScanner.
BUG=none
Committed: https://crrev.com/8c6c59a21116cf7a1e055bf221c8de754b70f65e
Cr-Commit-Position: refs/heads/master@{#407752}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Changed formatting of launchQRScanner. #Messages
Total messages: 19 (8 generated)
sklencarova@google.com changed reviewers: + marq@chromium.org
drive-by https://codereview.chromium.org/2169463003/diff/1/ios/chrome/browser/app_star... File ios/chrome/browser/app_startup_parameters.mm (right): https://codereview.chromium.org/2169463003/diff/1/ios/chrome/browser/app_star... ios/chrome/browser/app_startup_parameters.mm:60: return (experimental_flags::IsQRCodeReaderEnabled() && _launchQRScanner); style: return is not a function, so remove superfluous parenthesis. nit: I would swap the two checks to avoid a function call if _launchQRScanner is NO.
https://codereview.chromium.org/2169463003/diff/1/ios/chrome/browser/app_star... File ios/chrome/browser/app_startup_parameters.mm (right): https://codereview.chromium.org/2169463003/diff/1/ios/chrome/browser/app_star... ios/chrome/browser/app_startup_parameters.mm:60: return (experimental_flags::IsQRCodeReaderEnabled() && _launchQRScanner); On 2016/07/20 14:18:54, sdefresne wrote: > style: return is not a function, so remove superfluous parenthesis. > > nit: I would swap the two checks to avoid a function call if _launchQRScanner is > NO. Done.
lgtm
The CQ bit was checked by sklencarova@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Add an experimental settings check into the getter for launchQRScanner. BUG=none ========== to ========== Add an experimental settings check into the getter for launchQRScanner. BUG=none ==========
sklencarova@google.com changed reviewers: + sdefresne@chromium.org
lgtm
The CQ bit was checked by sklencarova@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add an experimental settings check into the getter for launchQRScanner. BUG=none ========== to ========== Add an experimental settings check into the getter for launchQRScanner. BUG=none ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add an experimental settings check into the getter for launchQRScanner. BUG=none ========== to ========== Add an experimental settings check into the getter for launchQRScanner. BUG=none Committed: https://crrev.com/8c6c59a21116cf7a1e055bf221c8de754b70f65e Cr-Commit-Position: refs/heads/master@{#407752} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8c6c59a21116cf7a1e055bf221c8de754b70f65e Cr-Commit-Position: refs/heads/master@{#407752} |
