Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2169463002: [debugger] use absolute source positions for break locations. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] use absolute source positions for break locations. There is simply no point in converting between relative and absolute source positions in both C++ and Javascript code. R=jgruber@chromium.org Committed: https://crrev.com/ad4eb051e7315915ee9dac72c82b4af94952ab77 Cr-Commit-Position: refs/heads/master@{#37916}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -62 lines) Patch
M src/debug/debug.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/debug/debug.cc View 7 chunks +15 lines, -23 lines 0 comments Download
M src/debug/debug.js View 1 5 chunks +6 lines, -15 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +15 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years, 5 months ago (2016-07-20 13:38:03 UTC) #1
jgruber
lgtm with nit. https://codereview.chromium.org/2169463002/diff/1/src/debug/debug.js File src/debug/debug.js (right): https://codereview.chromium.org/2169463002/diff/1/src/debug/debug.js#newcode587 src/debug/debug.js:587: var source_position = break_position; It looks ...
4 years, 5 months ago (2016-07-20 14:09:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169463002/20001
4 years, 5 months ago (2016-07-21 05:43:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 06:29:31 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 06:30:49 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad4eb051e7315915ee9dac72c82b4af94952ab77
Cr-Commit-Position: refs/heads/master@{#37916}

Powered by Google App Engine
This is Rietveld 408576698