chrome/browser/ui/views/content_setting_bubble_contents.h - Issue 2169453003: Hide protocol handler icon in location bar after user is done

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/content_setting_bubble_contents.h

Issue 2169453003: Hide protocol handler icon in location bar after user is done (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('K') | « chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('k') | chrome/browser/ui/views/content_setting_bubble_contents.cc » ('j') | chrome/browser/ui/views/content_setting_bubble_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/content_setting_bubble_contents.h

diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.h b/chrome/browser/ui/views/content_setting_bubble_contents.h

index 965e5f08a264d3ab473c1d05a83c84c9b066f5f0..efd43d8a6e9ea380b9fe1968ca52df2a91c67427 100644

--- a/chrome/browser/ui/views/content_setting_bubble_contents.h

+++ b/chrome/browser/ui/views/content_setting_bubble_contents.h

@@ -59,6 +59,8 @@ class ContentSettingBubbleContents : public content::WebContentsObserver,

// views::BubbleDialogDelegateView:

void Init() override;

View* CreateExtraView() override;

+ bool Accept() override;

+ bool Close() override;

int GetDialogButtons() const override;

base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;

@@ -116,7 +118,6 @@ class ContentSettingBubbleContents : public content::WebContentsObserver,

views::Link* custom_link_;

views::Link* manage_link_;

views::Link* learn_more_link_;

- views::LabelButton* close_button_;

// Combobox models the bubble owns.

std::list<MediaComboboxModel> combobox_models_;