chrome/browser/ui/content_settings/content_setting_bubble_model.h - Issue 2169453003: Hide protocol handler icon in location bar after user is done

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.h

Issue 2169453003: Hide protocol handler icon in location bar after user is done (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/content_settings/content_setting_bubble_model.cc » ('j') | chrome/browser/ui/content_settings/content_setting_bubble_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model.h

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.h b/chrome/browser/ui/content_settings/content_setting_bubble_model.h

index 93c1d624c13b1eb467aa5144175e30ff67acb917..a7b5aaf11800c3bc6620f9563d729eedf7563689 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.h

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.h

@@ -260,6 +260,7 @@ class ContentSettingRPHBubbleModel : public ContentSettingSimpleBubbleModel {

content::WebContents* web_contents,

Profile* profile,

ProtocolHandlerRegistry* registry);

+ ~ContentSettingRPHBubbleModel() override;

void OnRadioClicked(int radio_index) override;

void OnDoneClicked() override;

@@ -271,6 +272,9 @@ class ContentSettingRPHBubbleModel : public ContentSettingSimpleBubbleModel {

void ClearOrSetPreviousHandler();

int selected_item_;

+ // Initially false, set to true if the user explicitly interacts with the

msw 2016/07/20 20:50:16 optional nit: remove 'explicitly' for a one-liner

+ // bubble.

+ bool interacted_;

ProtocolHandlerRegistry* registry_;

ProtocolHandler pending_handler_;

ProtocolHandler previous_handler_;