[gn] Properly qualify variable names that escape v8 context

[gn] Properly qualify variable names that escape v8 context

This prepares for relanding:
https://codereview.chromium.org/2058033002/

All toplevel variables are visible in files including v8.gni.
This works around potential name clashes.

BUG=chromium:616034
Committed: https://crrev.com/d02290ceb9c466e703b5386d2d28933c220ae4f7
Cr-Commit-Position: refs/heads/master@{#37896}

[Michael Achenbach, 2016-07-20 08:34:53]

Description was changed from

==========
[gn] Properly qualify variable names that escape v8 context

BUG=
==========

to

==========
[gn] Properly qualify variable names that escape v8 context

This prepares for relanding:
https://codereview.chromium.org/2058033002/

BUG=chromium:616034
==========

[Michael Achenbach, 2016-07-20 08:34:53]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-07-20 08:35:08]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 08:35:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-07-20 08:37:39]

Description was changed from

==========
[gn] Properly qualify variable names that escape v8 context

This prepares for relanding:
https://codereview.chromium.org/2058033002/

BUG=chromium:616034
==========

to

==========
[gn] Properly qualify variable names that escape v8 context

This prepares for relanding:
https://codereview.chromium.org/2058033002/

All toplevel variables are visible in files including v8.gni.
This works around potential name clashes.

BUG=chromium:616034
==========

[Michael Achenbach, 2016-07-20 08:37:54]

PTAL

[Michael Achenbach, 2016-07-20 08:39:29]

An even better solution would probably be to split this into two v8.gni files.
One included in chromium and v8. And one with the things only useful for v8 (the
templates).

[vogelheim, 2016-07-20 08:54:44]

lgtm

[commit-bot: I haz the power, 2016-07-20 09:05:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 09:05:13]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-07-20 09:13:46]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-20 09:13:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 09:16:30]

Description was changed from

==========
[gn] Properly qualify variable names that escape v8 context

This prepares for relanding:
https://codereview.chromium.org/2058033002/

All toplevel variables are visible in files including v8.gni.
This works around potential name clashes.

BUG=chromium:616034
==========

to

==========
[gn] Properly qualify variable names that escape v8 context

This prepares for relanding:
https://codereview.chromium.org/2058033002/

All toplevel variables are visible in files including v8.gni.
This works around potential name clashes.

BUG=chromium:616034
==========

[commit-bot: I haz the power, 2016-07-20 09:16:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-20 09:19:05]

Description was changed from

==========
[gn] Properly qualify variable names that escape v8 context

This prepares for relanding:
https://codereview.chromium.org/2058033002/

All toplevel variables are visible in files including v8.gni.
This works around potential name clashes.

BUG=chromium:616034
==========

to

==========
[gn] Properly qualify variable names that escape v8 context

This prepares for relanding:
https://codereview.chromium.org/2058033002/

All toplevel variables are visible in files including v8.gni.
This works around potential name clashes.

BUG=chromium:616034

Committed: https://crrev.com/d02290ceb9c466e703b5386d2d28933c220ae4f7
Cr-Commit-Position: refs/heads/master@{#37896}
==========

[commit-bot: I haz the power, 2016-07-20 09:19:07]

Patchset 1 (id:??) landed as
https://crrev.com/d02290ceb9c466e703b5386d2d28933c220ae4f7
Cr-Commit-Position: refs/heads/master@{#37896}