Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2169433003: MD History: remove underline/bgcolor change on :hover (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: remove underline/bgcolor change on :hover R=tsergeant@chromium.org BUG=630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a719eb30f9a516530e587612cd9461d44a9e7444 Cr-Commit-Position: refs/heads/master@{#406978}

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M chrome/browser/resources/md_history/list_container.html View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/shared_style.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Dan Beam
4 years, 5 months ago (2016-07-21 04:52:45 UTC) #2
tsergeant
lgtm
4 years, 5 months ago (2016-07-21 05:11:51 UTC) #3
tsergeant
https://codereview.chromium.org/2169433003/diff/1/chrome/browser/resources/md_history/history_list.html File chrome/browser/resources/md_history/history_list.html (left): https://codereview.chromium.org/2169433003/diff/1/chrome/browser/resources/md_history/history_list.html#oldcode29 chrome/browser/resources/md_history/history_list.html:29: paper-item:hover { You lost a race with calamity, you'll ...
4 years, 5 months ago (2016-07-21 07:12:17 UTC) #4
Dan Beam
https://codereview.chromium.org/2169433003/diff/1/chrome/browser/resources/md_history/history_list.html File chrome/browser/resources/md_history/history_list.html (left): https://codereview.chromium.org/2169433003/diff/1/chrome/browser/resources/md_history/history_list.html#oldcode29 chrome/browser/resources/md_history/history_list.html:29: paper-item:hover { On 2016/07/21 07:12:17, tsergeant wrote: > You ...
4 years, 5 months ago (2016-07-21 21:45:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169433003/20001
4 years, 5 months ago (2016-07-21 21:46:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 22:49:22 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:50:36 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a719eb30f9a516530e587612cd9461d44a9e7444
Cr-Commit-Position: refs/heads/master@{#406978}

Powered by Google App Engine
This is Rietveld 408576698