Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4035)

Unified Diff: chrome/common/extensions/docs/server2/api_data_source_test.py

Issue 216943006: Remove ReferenceResolver dependency in APIDataSource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove ReferenceResolver.Factory Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/api_data_source_test.py
diff --git a/chrome/common/extensions/docs/server2/api_data_source_test.py b/chrome/common/extensions/docs/server2/api_data_source_test.py
index e842576f633e2a6bdc6f37f6529fc99318ade7a0..c6861693a76ada6477c110692e3f174cad591fbd 100755
--- a/chrome/common/extensions/docs/server2/api_data_source_test.py
+++ b/chrome/common/extensions/docs/server2/api_data_source_test.py
@@ -18,7 +18,6 @@ from features_bundle import FeaturesBundle
from file_system import FileNotFoundError
from future import Future
from object_store_creator import ObjectStoreCreator
-from reference_resolver import ReferenceResolver
from server_instance import ServerInstance
from test_data.canned_data import (CANNED_API_FILE_SYSTEM_DATA, CANNED_BRANCHES)
from test_data.api_data_source.canned_trunk_fs import CANNED_TRUNK_FS_DATA
@@ -106,19 +105,12 @@ class APIDataSourceTest(unittest.TestCase):
with open(os.path.join(self._base_path, filename), 'r') as f:
return f.read()
- def _CreateRefResolver(self, filename):
- test_data = self._LoadJSON(filename)
- return ReferenceResolver.Factory(_FakeAPIDataSource(test_data),
- _FakeAPIModels(test_data),
- ObjectStoreCreator.ForTest()).Create()
-
def _LoadJSON(self, filename):
return json.loads(self._ReadLocalFile(filename))
def testCreateId(self):
dict_ = _JSCModel('tester',
self._api_models,
- self._CreateRefResolver('test_file_data_source.json'),
False,
_FakeAvailabilityFinder(),
self._json_cache,
@@ -137,7 +129,6 @@ class APIDataSourceTest(unittest.TestCase):
dict_ = _JSCModel('tester',
self._api_models,
False,
- self._CreateRefResolver('test_file_data_source.json'),
_FakeAvailabilityFinder(),
self._json_cache,
_FakeTemplateCache(),
@@ -150,28 +141,6 @@ class APIDataSourceTest(unittest.TestCase):
self.assertEquals('67', _FormatValue(67))
self.assertEquals('234,567', _FormatValue(234567))
- def testFormatDescription(self):
- dict_ = _JSCModel('ref_test',
- self._api_models,
- self._CreateRefResolver('ref_test_data_source.json'),
- False,
- _FakeAvailabilityFinder(),
- self._json_cache,
- _FakeTemplateCache(),
- self._features_bundle,
- None).ToDict()
- self.assertEquals(_MakeLink('ref_test.html#type-type2', 'type2'),
- _GetType(dict_, 'type1')['description'])
- self.assertEquals(
- 'A %s, or %s' % (_MakeLink('ref_test.html#type-type3', 'type3'),
- _MakeLink('ref_test.html#type-type2', 'type2')),
- _GetType(dict_, 'type2')['description'])
- self.assertEquals(
- '%s != %s' % (_MakeLink('other.html#type-type2', 'other.type2'),
- _MakeLink('ref_test.html#type-type2', 'type2')),
- _GetType(dict_, 'type3')['description'])
-
-
def testGetApiAvailability(self):
api_availabilities = {
'bluetooth': ChannelInfo('dev', CANNED_BRANCHES[28], 28),
@@ -184,7 +153,6 @@ class APIDataSourceTest(unittest.TestCase):
for api_name, availability in api_availabilities.iteritems():
model = _JSCModel(api_name,
self._avail_api_models,
- None,
True,
self._avail_finder,
self._avail_json_cache,
@@ -196,7 +164,6 @@ class APIDataSourceTest(unittest.TestCase):
def testGetIntroList(self):
model = _JSCModel('tester',
self._api_models,
- self._CreateRefResolver('test_file_data_source.json'),
False,
_FakeAvailabilityFinder(),
self._json_cache,
@@ -269,7 +236,6 @@ class APIDataSourceTest(unittest.TestCase):
def testAddRules(self):
dict_ = _JSCModel('add_rules_tester',
self._api_models,
- self._CreateRefResolver('test_file_data_source.json'),
False,
_FakeAvailabilityFinder(),
self._json_cache,

Powered by Google App Engine
This is Rietveld 408576698