chrome/common/extensions/docs/server2/document_renderer_test.py - Issue 216943006: Remove ReferenceResolver dependency in APIDataSource.

Unified Diff: chrome/common/extensions/docs/server2/document_renderer_test.py

Issue 216943006: Remove ReferenceResolver dependency in APIDataSource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/document_renderer.py ('K') | « chrome/common/extensions/docs/server2/document_renderer.py ('k') | chrome/common/extensions/docs/server2/server_instance.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/document_renderer_test.py

diff --git a/chrome/common/extensions/docs/server2/document_renderer_test.py b/chrome/common/extensions/docs/server2/document_renderer_test.py

index 757f4722691fc72db448960c662bca2a80062fb3..ac0e90cb27ff1259a8b1178e9a95a23630221dfc 100755

--- a/chrome/common/extensions/docs/server2/document_renderer_test.py

+++ b/chrome/common/extensions/docs/server2/document_renderer_test.py

@@ -116,14 +116,15 @@ class DocumentRendererUnittest(unittest.TestCase):

self.assertEqual(['Expected a title'], warnings)

def testInvalidRef(self):

- # There needs to be more than 100 characters between the invalid ref

+ # There needs to be more than 110 characters between the invalid ref

ahernandez 2014/03/28 19:04:52 WDYT about changing this comment to be a bit more

not at google - send to devlin 2014/03/28 21:48:22 sgtm

ahernandez 2014/03/28 22:03:25 Do you have any suggestions? I was having trouble

not at google - send to devlin 2014/03/28 22:08:44 Sure, how about, "DocumentRenderer attempts to det

# and the next ref

document = ('An invalid $(ref:foo.foo_t3 a title with some long '

- 'text containing a valid reference pointing to '

+ 'text containing a valid reference pointing to a thing called '

'$(ref:baz.baz_e1) here')

expected_document = ('An invalid $(ref:foo.foo_t3 a title with some long '

- 'text containing a valid reference pointing to <a'

- ' href=#type-baz_e1>baz.baz_e1</a> here')

+ 'text containing a valid reference pointing to a '

+ 'thing called <a href=#type-baz_e1>baz.baz_e1</a> '

+ 'here')

path = 'some/path/to/document_api.html'

text, warnings = self._renderer.Render(document, path)