Issue 216943002: Componentize SigninErrorController unittest.

Issue 216943002: Componentize SigninErrorController unittest. (Closed)

Created:
6 years, 9 months ago by blundell

Modified:
6 years, 9 months ago

Reviewers:
droger, Roger Tawa OOO till Jul 10th, jochen (gone - plz use gerrit)

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org, Roger Tawa OOO till Jul 10th

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Componentize SigninErrorController unittest. No changes are required beyond removing a stale include and componentizing FakeAuthStatusProvider (which can be componentized as-is). BUG=334000 TBR=jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260262

Patch Set 1 #

Total comments: 2

Patch Set 2 : Response to review #

Patch Set 3 : Add missing dependency #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -346 lines)			Patch
D	chrome/browser/signin/fake_auth_status_provider.h	View		1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/browser/signin/fake_auth_status_provider.cc	View		1 chunk	+0 lines, -30 lines	0 comments	Download
D	chrome/browser/signin/signin_error_controller_unittest.cc	View		1 chunk	+0 lines, -255 lines	0 comments	Download
M	chrome/browser/signin/signin_error_notifier_ash_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/signin/signin_global_error_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/signin/signin_tracker_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/sync_ui_util_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_unittest.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download
M	components/components_tests.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	components/signin.gypi	View	1	1 chunk	+22 lines, -8 lines	0 comments	Download
A +	components/signin/core/browser/fake_auth_status_provider.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/signin/core/browser/fake_auth_status_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	components/signin/core/browser/signin_error_controller_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

droger

lgtm with nit; https://codereview.chromium.org/216943002/diff/1/components/signin.gypi File components/signin.gypi (right): https://codereview.chromium.org/216943002/diff/1/components/signin.gypi#newcode61 components/signin.gypi:61: 'signin/core/browser/mutable_profile_oauth2_token_service.h', Indentation.

6 years, 9 months ago (2014-03-28 12:37:10 UTC) #2

blundell

https://codereview.chromium.org/216943002/diff/1/components/signin.gypi File components/signin.gypi (right): https://codereview.chromium.org/216943002/diff/1/components/signin.gypi#newcode61 components/signin.gypi:61: 'signin/core/browser/mutable_profile_oauth2_token_service.h', On 2014/03/28 12:37:11, droger wrote: > Indentation. Done.

6 years, 9 months ago (2014-03-28 18:03:03 UTC) #4

blundell

TBR=jochen for include path changes in //chrome outside of //chrome/browser/signin

6 years, 9 months ago (2014-03-28 18:03:46 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/216943002/40001

6 years, 9 months ago (2014-03-28 18:05:00 UTC) #7

Message was sent while issue was closed.

Change committed as 260262

Expand Messages | Collapse Messages