Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2169343002: Initial value for mask-repeat property should be no-repeat (Closed)

Created:
4 years, 5 months ago by ramya.v
Modified:
4 years, 4 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initial value for mask-repeat property should be no-repeat Spec: https://www.w3.org/TR/css-masking-1/#the-mask-repeat BUG=628968 Committed: https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b Cr-Commit-Position: refs/heads/master@{#407435}

Patch Set 1 #

Patch Set 2 : Updated test case results #

Messages

Total messages: 14 (6 generated)
ramya.v
PTAL! Thanks
4 years, 5 months ago (2016-07-22 06:24:16 UTC) #2
Timothy Loh
On 2016/07/22 06:24:16, ramya.v wrote: > PTAL! > > Thanks lgtm
4 years, 4 months ago (2016-07-25 01:26:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169343002/1
4 years, 4 months ago (2016-07-25 03:45:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/268125) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years, 4 months ago (2016-07-25 04:54:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169343002/20001
4 years, 4 months ago (2016-07-25 08:00:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-25 09:14:22 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b Cr-Commit-Position: refs/heads/master@{#407435}
4 years, 4 months ago (2016-07-25 09:15:32 UTC) #13
Michael Moss
4 years, 3 months ago (2016-09-13 21:52:06 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2332373003/ by mmoss@chromium.org.

The reason for reverting is: This appears to be causing crbug.com/645000
.

Powered by Google App Engine
This is Rietveld 408576698