Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2169313002: Converted Observatory vm-connect-target element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added missing file from observatory_sources.gypi #

Patch Set 3 : Added Uris helper function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -66 lines) Patch
M runtime/observatory/lib/elements.dart View 1 3 chunks +5 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.dart View 2 chunks +1 line, -42 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.html View 1 chunk +0 lines, -25 lines 0 comments Download
A runtime/observatory/lib/src/elements/vm_connect_target.dart View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/vm_connect_target_wrapper.dart View 1 chunk +77 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.dart View 1 chunk +94 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-22 04:47:12 UTC) #2
Cutch
lgtm
4 years, 5 months ago (2016-07-22 13:41:36 UTC) #3
rmacnak
lgtm https://chromiumcodereview.appspot.com/2169313002/diff/1/runtime/observatory/lib/src/models/objects/target.dart File runtime/observatory/lib/src/models/objects/target.dart (right): https://chromiumcodereview.appspot.com/2169313002/diff/1/runtime/observatory/lib/src/models/objects/target.dart#newcode7 runtime/observatory/lib/src/models/objects/target.dart:7: abstract class Target{ Target {
4 years, 5 months ago (2016-07-22 20:08:45 UTC) #4
cbernaschina
https://codereview.chromium.org/2169313002/diff/1/runtime/observatory/lib/src/models/objects/target.dart File runtime/observatory/lib/src/models/objects/target.dart (right): https://codereview.chromium.org/2169313002/diff/1/runtime/observatory/lib/src/models/objects/target.dart#newcode7 runtime/observatory/lib/src/models/objects/target.dart:7: abstract class Target{ On 2016/07/22 20:08:45, rmacnak wrote: > ...
4 years, 5 months ago (2016-07-22 23:57:31 UTC) #5
cbernaschina
4 years, 5 months ago (2016-07-23 00:01:19 UTC) #6
cbernaschina
4 years, 5 months ago (2016-07-23 00:04:51 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
d2a5586289ecf2387845d26c32994408194e156e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698