Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2169293002: [turbofan] Improve lowering for NumberAbs to Int32Abs. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve lowering for NumberAbs to Int32Abs. We can compute the absolute integer value w/o any conditional execution by using the bit trick formula let sign = input >> 31 in (input ^ sign) - sign which generates fairly decent code on all supported architectures. R=jarin@chromium.org Committed: https://crrev.com/085ec5c25f9dd1cc51914d90c3e0aa1c45d002fe Cr-Commit-Position: refs/heads/master@{#37965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-22 03:44:32 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a better non-branchy version of integer Math.abs. Please take a look. Thanks, ...
4 years, 5 months ago (2016-07-22 03:56:54 UTC) #4
Jarin
lgtm
4 years, 5 months ago (2016-07-22 04:31:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169293002/1
4 years, 5 months ago (2016-07-22 04:32:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 04:33:50 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 04:34:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/085ec5c25f9dd1cc51914d90c3e0aa1c45d002fe
Cr-Commit-Position: refs/heads/master@{#37965}

Powered by Google App Engine
This is Rietveld 408576698