Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2169273005: [tools/perf] Disable system_health.memory_desktop.browse:news:reddit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 21 matching lines...) Expand all
32 32
33 33
34 _DISABLED_TESTS = frozenset({ 34 _DISABLED_TESTS = frozenset({
35 # crbug.com/630686 35 # crbug.com/630686
36 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:nytimes', # pylint: disable=line-too-long 36 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:nytimes', # pylint: disable=line-too-long
37 # crbug.com/622409 37 # crbug.com/622409
38 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:cnn', # pylint: disable=line-too-long 38 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:cnn', # pylint: disable=line-too-long
39 # crbug.com/629123 39 # crbug.com/629123
40 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:hackernews', # pylint: disable=line-too-long 40 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:hackernews', # pylint: disable=line-too-long
41 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:nytimes', # pylint: disable=line-too-long 41 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:nytimes', # pylint: disable=line-too-long
42 # crbug.com/630765
43 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:reddit', # pylint: disable=line-too-long
42 }) 44 })
43 45
44 46
45 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): 47 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
46 48
47 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 49 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
48 # 50 #
49 # This smoke test dynamically tests all system health user stories. So 51 # This smoke test dynamically tests all system health user stories. So
50 # disabling it for one failing or flaky benchmark would disable a much 52 # disabling it for one failing or flaky benchmark would disable a much
51 # wider swath of coverage than is usally intended. Instead, if a test is 53 # wider swath of coverage than is usally intended. Instead, if a test is
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 # parsed during test time which happens after load_tests are called. 127 # parsed during test time which happens after load_tests are called.
126 # Since none of our system health benchmarks creates stories based on 128 # Since none of our system health benchmarks creates stories based on
127 # command line options, it should be ok to pass options=None to 129 # command line options, it should be ok to pass options=None to
128 # CreateStorySet. 130 # CreateStorySet.
129 for story_to_smoke_test in ( 131 for story_to_smoke_test in (
130 benchmark_class().CreateStorySet(options=None).stories): 132 benchmark_class().CreateStorySet(options=None).stories):
131 suite.addTest( 133 suite.addTest(
132 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 134 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
133 135
134 return suite 136 return suite
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698