third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp - Issue 2169273004: Switch all LayoutTests to use new accessibility relative bounding box API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2169273004: Switch all LayoutTests to use new accessibility relative bounding box API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix absolute bounds in AXInlineTextBox::elementRect Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

index 3033dd2bf9cb17cbb7cfa85ac4049bb8e6536072..7df53a74a50a9c87e7d258b1f3cf56d67559efcf 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

@@ -36,6 +36,7 @@

#include "core/frame/LocalFrame.h"

#include "core/frame/Settings.h"

#include "core/html/HTMLAreaElement.h"

+#include "core/html/HTMLCanvasElement.h"

#include "core/html/HTMLImageElement.h"

#include "core/html/HTMLInputElement.h"

#include "core/html/HTMLLabelElement.h"

@@ -1265,13 +1266,17 @@ void AXObjectCacheImpl::onTouchAccessibilityHover(const IntPoint& location)

}

-void AXObjectCacheImpl::setCanvasObjectBounds(Element* element, const LayoutRect& rect)

+void AXObjectCacheImpl::setCanvasObjectBounds(HTMLCanvasElement* canvas, Element* element, const LayoutRect& rect)

{

AXObject* obj = getOrCreate(element);

if (!obj)

return;

- obj->setElementRect(rect);

+ AXObject* axCanvas = getOrCreate(canvas);

+ if (!axCanvas)

+ return;

+ obj->setElementRect(rect, axCanvas);

}

DEFINE_TRACE(AXObjectCacheImpl)