Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.h

Issue 2169273004: Switch all LayoutTests to use new accessibility relative bounding box API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix absolute bounds in AXInlineTextBox::elementRect Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXObject.h
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.h b/third_party/WebKit/Source/modules/accessibility/AXObject.h
index 8008f4c785812fca57202b268c6e4a4ef4b3a387..b69dc01c51945b9b41bde0082fda5d632a9b1af1 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObject.h
+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.h
@@ -823,7 +823,11 @@ public:
// Location and click point in frame-relative coordinates. DEPRECATED, to be
// replaced by getRelativeBounds.
virtual LayoutRect elementRect() const { return m_explicitElementRect; }
- void setElementRect(LayoutRect r) { m_explicitElementRect = r; }
+ void setElementRect(LayoutRect r, AXObject* container)
+ {
+ m_explicitElementRect = r;
+ m_explicitContainerID = container->axObjectID();
+ }
virtual void markCachedElementRectDirty() const;
virtual IntPoint clickPoint();
@@ -839,7 +843,7 @@ public:
// not null, walk up to its container and offset by the container's offset from
// origin, the container's scroll position if any, and apply the container's transform.
// Do this until you reach the root of the tree.
- virtual void getRelativeBounds(AXObject** container, FloatRect& boundsInContainer, SkMatrix44& containerTransform) const;
+ virtual void getRelativeBounds(AXObject** outContainer, FloatRect& outBoundsInContainer, SkMatrix44& outContainerTransform) const;
// Hit testing.
// Called on the root AX object to return the deepest available element.
@@ -950,6 +954,7 @@ protected:
AccessibilityRole m_role;
AXObjectInclusion m_lastKnownIsIgnoredValue;
LayoutRect m_explicitElementRect;
+ AXID m_explicitContainerID;
// Used only inside textAlternative():
static String collapseWhitespace(const String&);

Powered by Google App Engine
This is Rietveld 408576698