third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp - Issue 2169273004: Switch all LayoutTests to use new accessibility relative bounding box API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

Issue 2169273004: Switch all LayoutTests to use new accessibility relative bounding box API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix absolute bounds in AXInlineTextBox::elementRect Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h ('k') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

index 423778cc2663ce7594710417605b8611800268f1..98f36329bbbb9cc1ae5fe24a79a13df18580ba80 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

@@ -65,7 +65,20 @@ LayoutRect AXInlineTextBox::elementRect() const

if (!m_inlineTextBox)

return LayoutRect();

- return m_inlineTextBox->bounds();

+ return m_inlineTextBox->absoluteBounds();

+void AXInlineTextBox::getRelativeBounds(AXObject** outContainer, FloatRect& outBoundsInContainer, SkMatrix44& outContainerTransform) const

+ *outContainer = nullptr;

+ outBoundsInContainer = FloatRect();

+ outContainerTransform.setIdentity();

+ if (!m_inlineTextBox)

+ return;

+ *outContainer = parentObject();

+ outBoundsInContainer = FloatRect(m_inlineTextBox->localBounds());

}

bool AXInlineTextBox::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReasons) const