Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Issue 2169263005: [Android] Use --use-su w/ asan_device_setup.sh. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
Reviewers:
martiniss, xunjieli
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Use --use-su w/ asan_device_setup.sh. This should prevent the script from calling `adb root`, which can result in temporary connection issues immediately after it returns. BUG=630639 TBR=martiniss@chromium.org,xunjieli@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/d586d110fcce4de95de41660b820d624835aa8e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan_tester.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jbudorick
This may work, or it may do nothing -- I'm not sure. It's a much ...
4 years, 5 months ago (2016-07-22 16:08:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169263005/1
4 years, 5 months ago (2016-07-22 16:08:20 UTC) #5
jbudorick
On 2016/07/22 16:08:07, jbudorick wrote: > This may work, or it may do nothing -- ...
4 years, 5 months ago (2016-07-22 16:08:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/d586d110fcce4de95de41660b820d624835aa8e0
4 years, 5 months ago (2016-07-22 16:12:10 UTC) #8
jbudorick
4 years, 5 months ago (2016-07-22 17:33:26 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2174623003/ by jbudorick@chromium.org.

The reason for reverting is: su -c echo foo can't find echo..

Powered by Google App Engine
This is Rietveld 408576698