Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2169233003: Fix flaky CredentialManagerBrowserTest.SaveViaAPIAndAutofill. (Closed)

Created:
4 years, 5 months ago by vasilii
Modified:
4 years, 5 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky CredentialManagerBrowserTest.SaveViaAPIAndAutofill. BUG=629459 Committed: https://crrev.com/03e0adf02ebc86106a0a94444407c738873f6cb9 Cr-Commit-Position: refs/heads/master@{#407134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -19 lines) Patch
M chrome/browser/password_manager/credential_manager_browsertest.cc View 1 chunk +39 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
vasilii
Hi Vaclav, please review.
4 years, 5 months ago (2016-07-22 11:24:54 UTC) #4
vabr (Chromium)
LGTM, thank you for making the tests test what they should and working properly! Vaclav
4 years, 5 months ago (2016-07-22 11:42:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169233003/1
4 years, 5 months ago (2016-07-22 11:48:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 11:53:13 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 11:54:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03e0adf02ebc86106a0a94444407c738873f6cb9
Cr-Commit-Position: refs/heads/master@{#407134}

Powered by Google App Engine
This is Rietveld 408576698