Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216923004: Expose ImageData on WorkerGlobalScope. (Closed)

Created:
6 years, 9 months ago by sof
Modified:
6 years, 8 months ago
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Expose ImageData on WorkerGlobalScope. Follow the spec and also provide the ImageData interface object on WorkerGlobalScope. R=junov@chromium.org,eseidel@chromium.org BUG=355030 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170665

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adhere to script-tests/ constraint #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -70 lines) Patch
M LayoutTests/fast/canvas/canvas-ImageData-constructor.html View 1 1 chunk +8 lines, -2 lines 0 comments Download
A + LayoutTests/fast/canvas/canvas-ImageData-workers.html View 1 2 1 chunk +3 lines, -1 line 0 comments Download
A LayoutTests/fast/canvas/canvas-ImageData-workers-expected.txt View 1 1 chunk +42 lines, -0 lines 0 comments Download
A + LayoutTests/fast/canvas/resources/canvas-ImageData.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/fast/canvas/resources/canvas-ImageData-workers.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-ImageData.js View 1 1 chunk +0 lines, -67 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-dedicated-worker-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-shared-worker-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-dedicated-worker-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-shared-worker-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/ImageData.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
sof
When there's some time, please take a look. Do note that this will expose the ...
6 years, 9 months ago (2014-03-28 16:11:07 UTC) #1
Justin Novosad
+eseidel : OK to proceed or does this need formal API owner approval on blink-dev? ...
6 years, 9 months ago (2014-03-28 17:50:46 UTC) #2
Justin Novosad
https://codereview.chromium.org/216923004/diff/1/LayoutTests/fast/canvas/script-tests/canvas-ImageData.js File LayoutTests/fast/canvas/script-tests/canvas-ImageData.js (right): https://codereview.chromium.org/216923004/diff/1/LayoutTests/fast/canvas/script-tests/canvas-ImageData.js#newcode1 LayoutTests/fast/canvas/script-tests/canvas-ImageData.js:1: if ("importScripts" in this) This file should be moved ...
6 years, 9 months ago (2014-03-28 17:56:51 UTC) #3
sof
https://codereview.chromium.org/216923004/diff/1/LayoutTests/fast/canvas/script-tests/canvas-ImageData.js File LayoutTests/fast/canvas/script-tests/canvas-ImageData.js (right): https://codereview.chromium.org/216923004/diff/1/LayoutTests/fast/canvas/script-tests/canvas-ImageData.js#newcode1 LayoutTests/fast/canvas/script-tests/canvas-ImageData.js:1: if ("importScripts" in this) On 2014/03/28 17:56:51, junov wrote: ...
6 years, 9 months ago (2014-03-28 18:39:06 UTC) #4
sof
WebKit has landed support for this, https://bugs.webkit.org/show_bug.cgi?id=130668
6 years, 8 months ago (2014-03-29 19:35:54 UTC) #5
sof
With some extra LGTMs given, should we move ahead with this one?
6 years, 8 months ago (2014-04-02 06:03:40 UTC) #6
eseidel
lgtm
6 years, 8 months ago (2014-04-02 06:52:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/216923004/20001
6 years, 8 months ago (2014-04-02 06:52:45 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 06:53:08 UTC) #9
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/canvas/canvas-ImageData-workers.html: While running svn copy LayoutTests/fast/canvas/canvas-extremely-large-dimensions.html LayoutTests/fast/canvas/canvas-ImageData-workers.html --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive ...
6 years, 8 months ago (2014-04-02 06:53:08 UTC) #10
Justin Novosad
On 2014/04/02 06:53:08, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 8 months ago (2014-04-02 14:51:29 UTC) #11
sof
On 2014/04/02 14:51:29, junov wrote: ... > > Hah, that is such a bogus error. ...
6 years, 8 months ago (2014-04-02 14:56:07 UTC) #12
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-02 14:58:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/216923004/30001
6 years, 8 months ago (2014-04-02 14:58:01 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 15:56:19 UTC) #15
Message was sent while issue was closed. 
Change committed as 170665

Powered by Google App Engine
This is Rietveld 408576698