Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 216923003: Add pixel test for <select> -webkit-autofil style (Closed)

Created:
6 years, 9 months ago by ziran.sun
Modified:
6 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add pixel test for <select> -webkit-autofil style R=tkent@chromium.org BUG=58719 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170623

Patch Set 1 #

Patch Set 2 : upload file again #

Total comments: 1

Patch Set 3 : Update code as per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/select-autofilled.html View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/linux/fast/forms/select-autofilled-expected.png View Binary file 0 comments Download
A LayoutTests/platform/linux/fast/forms/select-autofilled-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ziran.sun
Pixel test for <select> -webkit-autofill style is now added :). Please review. Thanks!
6 years, 9 months ago (2014-03-28 14:36:23 UTC) #1
tkent
Would you add testRunner.setUseMockTheme(false) to the test in order to check the behavior with real ...
6 years, 8 months ago (2014-03-31 02:17:43 UTC) #2
ziran.sun
Code updated as per review comments. All comments have been addressed. Please review. Thanks!
6 years, 8 months ago (2014-04-01 15:53:45 UTC) #3
tkent
lgtm select-autofilled-expected.png doesn't look the latest result, but it's ok because the auto-rebaseline-bot will update ...
6 years, 8 months ago (2014-04-02 00:35:47 UTC) #4
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 8 months ago (2014-04-02 00:35:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/216923003/40001
6 years, 8 months ago (2014-04-02 00:35:55 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 01:43:22 UTC) #7
Message was sent while issue was closed.
Change committed as 170623

Powered by Google App Engine
This is Rietveld 408576698