Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2169213002: DevTools: Sourcemap failure shouldn't open console drawer. (Closed)

Created:
4 years, 5 months ago by paulirish
Modified:
4 years, 5 months ago
Reviewers:
lushnikov, luoe, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Sourcemap failure shouldn't open console drawer. BUG=624038, 497094 Committed: https://crrev.com/6577e9c2199e226fb59c1b15fcc8dc89e245752b Cr-Commit-Position: refs/heads/master@{#407079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
paulirish
4 years, 5 months ago (2016-07-22 00:03:50 UTC) #2
pfeldman
lgtm
4 years, 5 months ago (2016-07-22 04:09:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169213002/1
4 years, 5 months ago (2016-07-22 04:10:05 UTC) #7
lushnikov
lgtm
4 years, 5 months ago (2016-07-22 04:52:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 06:19:46 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 06:21:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6577e9c2199e226fb59c1b15fcc8dc89e245752b
Cr-Commit-Position: refs/heads/master@{#407079}

Powered by Google App Engine
This is Rietveld 408576698