Settings: shared css: add .settings-box.single-column

Settings: shared css: add .settings-box.single-column

This should make it a little bit simpler for the somewhat common case
of a single column settings-box (20 / 60 existing two-line instances,
with more to come in internet settings).

BUG=589630
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a1b402e7b1d703169ea624ecdce4d94db1cd0d82
Cr-Commit-Position: refs/heads/master@{#407322}

[stevenjb, 2016-07-22 21:04:19]

Description was changed from

==========
Settings: shared css: add .settings-box.single-column

This should make it a little bit simpler for the somewhat common case
of a single column settings-box (20 / 60 existing two-line instances,
with more to come in internet settings).

BUG=589630
==========

to

==========
Settings: shared css: add .settings-box.single-column

This should make it a little bit simpler for the somewhat common case
of a single column settings-box (20 / 60 existing two-line instances,
with more to come in internet settings).

BUG=589630
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-07-22 21:12:04]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org, dschuyler@chromium.org

[stevenjb, 2016-07-22 21:12:05]

Changing the default settings-box or two-line behavior would have been more
changes, so I went with a "single-column" class. LMKWYT.

https://codereview.chromium.org/2169193003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(left):

https://codereview.chromium.org/2169193003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.html:104: <div
class="secondary">$i18n{chooseFontsAndEncoding}</div>
Note: incorrect indent

https://codereview.chromium.org/2169193003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/sync_page.html (left):

https://codereview.chromium.org/2169193003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/sync_page.html:134: </div>
This pattern resulted in the same layout as the more common pattern; I verified
that the new layout matches the old layout. (I verified all of the changes, but
double checked this one).

[dschuyler, 2016-07-22 22:24:18]

lgtm

[Dan Beam, 2016-07-22 23:18:42]

lgtm

https://codereview.chromium.org/2169193003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2169193003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:285: * necessarily
used in combination with two-line.
nit: I know you're just kind of following the comment above, but

/* A settings box with a single start-aligned column, generally but not
 * necessarily used in combination with two-line. */

is more compact and common in CSS across webui

[stevenjb, 2016-07-22 23:44:42]

https://codereview.chromium.org/2169193003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2169193003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:285: * necessarily
used in combination with two-line.
On 2016/07/22 23:18:42, Dan Beam wrote:
> nit: I know you're just kind of following the comment above, but
> 
> /* A settings box with a single start-aligned column, generally but not
>  * necessarily used in combination with two-line. */
> 
> is more compact and common in CSS across webui

Acknowledged.

[stevenjb, 2016-07-22 23:44:48]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2016-07-22 23:45:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 00:51:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-23 00:53:31]

Description was changed from

==========
Settings: shared css: add .settings-box.single-column

This should make it a little bit simpler for the somewhat common case
of a single column settings-box (20 / 60 existing two-line instances,
with more to come in internet settings).

BUG=589630
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: shared css: add .settings-box.single-column

This should make it a little bit simpler for the somewhat common case
of a single column settings-box (20 / 60 existing two-line instances,
with more to come in internet settings).

BUG=589630
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a1b402e7b1d703169ea624ecdce4d94db1cd0d82
Cr-Commit-Position: refs/heads/master@{#407322}
==========

[commit-bot: I haz the power, 2016-07-23 00:53:32]

Patchset 2 (id:??) landed as
https://crrev.com/a1b402e7b1d703169ea624ecdce4d94db1cd0d82
Cr-Commit-Position: refs/heads/master@{#407322}