Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2169193002: Re-land: Roll gtest.

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 4 months ago
Reviewers:
Paweł Hajdan Jr., tzik
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Roll gtest. The change in directory structure requires the checkout to be moved to a different directory, and some dummy header files that re-direct to the new location. Original change: https://codereview.chromium.org/2163573002/ This change differs from the original due to a rebase update from https://codereview.chromium.org/2168983002/ BUG=630705

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -292 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 1 1 chunk +2 lines, -2 lines 0 comments Download
D build/secondary/testing/gtest/BUILD.gn View 1 1 chunk +0 lines, -132 lines 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/gtest.gyp View 1 4 chunks +5 lines, -4 lines 0 comments Download
M testing/gtest.gypi View 1 chunk +28 lines, -8 lines 0 comments Download
A + testing/gtest/BUILD.gn View 1 4 chunks +31 lines, -26 lines 0 comments Download
A + testing/gtest/include/gtest/gtest.h View 1 chunk +1 line, -1 line 0 comments Download
A + testing/gtest/include/gtest/gtest-death-test.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-message.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-param-test.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-printers.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-spi.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-test-part.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-typed-test.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest_pred_impl.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest_prod.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-death-test-internal.h View 1 chunk +1 line, -1 line 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-filepath.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-internal.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-linked_ptr.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-param-util.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-param-util-generated.h View 1 chunk +1 line, -1 line 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-port.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-port-arch.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-string.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-tuple.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-type-util.h View 1 chunk +1 line, -6 lines 0 comments Download
M testing/gtest_nacl.gyp View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/licenses.py View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Anand Mistry (off Chromium)
tzik: Because of https://codereview.chromium.org/2168983002/ and I know you're doing something in this area.
4 years, 5 months ago (2016-07-22 02:53:40 UTC) #6
tzik
lgtm
4 years, 5 months ago (2016-07-22 03:16:49 UTC) #7
Paweł Hajdan Jr.
LGTM
4 years, 5 months ago (2016-07-22 13:22:51 UTC) #9
gab
On 2016/07/22 13:22:51, Paweł Hajdan (OOO back Aug 1) wrote: > LGTM Thanks for doing ...
4 years, 5 months ago (2016-07-25 13:53:16 UTC) #10
gab
On 2016/07/25 13:53:16, gab wrote: > On 2016/07/22 13:22:51, Paweł Hajdan (OOO back Aug 1) ...
4 years, 5 months ago (2016-07-25 14:00:46 UTC) #12
Anand Mistry (off Chromium)
4 years, 4 months ago (2016-07-27 00:51:12 UTC) #13
On 2016/07/25 14:00:46, gab wrote:
> On 2016/07/25 13:53:16, gab wrote:
> > On 2016/07/22 13:22:51, Paweł Hajdan (OOO back Aug 1) wrote:
> > > LGTM
> > 
> > Thanks for doing this, but I think we should wait for the resolution of the
> > chromium-dev thread before landing this CL:
> >
>
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/CgVbE6tM1qE/dis....
> 
> FYI added bug # to this CL, discussion is happening there:
> http://crbug.com/630705

I don't have the ability to pursue this any more. Feel free to use this as the
basis of your own roll.

Powered by Google App Engine
This is Rietveld 408576698