Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2169183002: PPC: [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations. (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations. Port 8aeb7439c91eb769f752ce87f6fc286c30761580 Fix for ppc file, using macro functions to xor and add to handle the case when kPrimaryMagic/kSecondaryMagic is > 16bits. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/0145ba864ba41f3e9f4bfe550cab23eb5b5e93c6 Cr-Commit-Position: refs/heads/master@{#37960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ic/ppc/stub-cache-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-07-21 22:48:12 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-07-21 23:52:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169183002/1
4 years, 5 months ago (2016-07-22 01:19:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 01:43:28 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 01:44:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0145ba864ba41f3e9f4bfe550cab23eb5b5e93c6
Cr-Commit-Position: refs/heads/master@{#37960}

Powered by Google App Engine
This is Rietveld 408576698