Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2169173002: arc: Fix legacy strings for OptIn flow. (Closed)

Created:
4 years, 5 months ago by khmel
Modified:
4 years, 5 months ago
Reviewers:
elijahtaylor1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Fix legacy strings for OptIn flow. BUG=630719 TEST=N/A Committed: https://crrev.com/257528980238608146ee8fdb694112cf971ab293 Cr-Commit-Position: refs/heads/master@{#407247}

Patch Set 1 #

Patch Set 2 : Learn more link add to location service optin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
khmel
Hi Elijah, PTAL
4 years, 5 months ago (2016-07-21 22:36:13 UTC) #2
elijahtaylor1
On 2016/07/21 22:36:13, khmel wrote: > Hi Elijah, > > PTAL lgtm. If you're going ...
4 years, 5 months ago (2016-07-22 19:38:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169173002/20001
4 years, 5 months ago (2016-07-22 19:46:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 20:25:45 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 20:29:12 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/257528980238608146ee8fdb694112cf971ab293
Cr-Commit-Position: refs/heads/master@{#407247}

Powered by Google App Engine
This is Rietveld 408576698