Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2169153002: DevTools: make all timeline trace events use 0-based line numbers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update expectation Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 * @param {!WebInspector.TimelineModel} model 8 * @param {!WebInspector.TimelineModel} model
9 * @param {!Array<!WebInspector.TimelineModel.Filter>} filters 9 * @param {!Array<!WebInspector.TimelineModel.Filter>} filters
10 */ 10 */
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 * @return {?Element} 85 * @return {?Element}
86 */ 86 */
87 _linkifyLocation: function(event) 87 _linkifyLocation: function(event)
88 { 88 {
89 var target = this._model.targetByEvent(event); 89 var target = this._model.targetByEvent(event);
90 if (!target) 90 if (!target)
91 return null; 91 return null;
92 var frame = WebInspector.TimelineProfileTree.eventStackFrame(event); 92 var frame = WebInspector.TimelineProfileTree.eventStackFrame(event);
93 if (!frame) 93 if (!frame)
94 return null; 94 return null;
95 return event.name === WebInspector.TimelineModel.RecordType.JSFrame 95 return this._linkifier.maybeLinkifyConsoleCallFrame(target, frame);
96 ? this._linkifier.maybeLinkifyConsoleCallFrame(target, frame)
97 : this._linkifier.maybeLinkifyConsoleCallFrameForTracing(target, fra me);
98 }, 96 },
99 97
100 /** 98 /**
101 * @param {!WebInspector.TimelineProfileTree.Node} treeNode 99 * @param {!WebInspector.TimelineProfileTree.Node} treeNode
102 * @param {boolean} suppressSelectedEvent 100 * @param {boolean} suppressSelectedEvent
103 */ 101 */
104 selectProfileNode: function(treeNode, suppressSelectedEvent) 102 selectProfileNode: function(treeNode, suppressSelectedEvent)
105 { 103 {
106 var pathToRoot = []; 104 var pathToRoot = [];
107 for (var node = treeNode; node; node = node.parent) 105 for (var node = treeNode; node; node = node.parent)
(...skipping 775 matching lines...) Expand 10 before | Expand all | Expand 10 after
883 return selectedNode && /** @type {!WebInspector.TimelineTreeView.GridNod e} */ (selectedNode)._profileNode; 881 return selectedNode && /** @type {!WebInspector.TimelineTreeView.GridNod e} */ (selectedNode)._profileNode;
884 }, 882 },
885 883
886 _onSelectionChanged: function() 884 _onSelectionChanged: function()
887 { 885 {
888 this.dispatchEventToListeners(WebInspector.TimelineStackView.Events.Sele ctionChanged); 886 this.dispatchEventToListeners(WebInspector.TimelineStackView.Events.Sele ctionChanged);
889 }, 887 },
890 888
891 __proto__: WebInspector.VBox.prototype 889 __proto__: WebInspector.VBox.prototype
892 } 890 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698