Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2169143003: [debugging] print ranges for consecutive values with %DebugPrint (Closed)

Created:
4 years, 5 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugging] print ranges for consecutive values with %DebugPrint With this CL repeated values in elements are combined into a single printout with a range. BEFORE: - elements = { 0: <undefined> 1: <undefined> 2: <the_hole> } AFTER: - elements = { 0-1: <undefined> 2: <the_hole> } BUG= Committed: https://crrev.com/ec4165742088043d8fede38db21a281e16682adb Cr-Commit-Position: refs/heads/master@{#38069}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixing the_hole and NaN printing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -34 lines) Patch
M src/objects-printer.cc View 1 4 chunks +63 lines, -34 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Camillo Bruni
PTAL
4 years, 4 months ago (2016-07-26 13:29:25 UTC) #4
Yang
On 2016/07/26 13:29:25, Camillo Bruni wrote: > PTAL lgtm!
4 years, 4 months ago (2016-07-26 13:32:30 UTC) #5
Yang
https://codereview.chromium.org/2169143003/diff/1/src/objects-printer.cc File src/objects-printer.cc (right): https://codereview.chromium.org/2169143003/diff/1/src/objects-printer.cc#newcode331 src/objects-printer.cc:331: bool values_are_nan = previous_value != previous_value && value != ...
4 years, 4 months ago (2016-07-26 13:33:43 UTC) #6
Yang
https://codereview.chromium.org/2169143003/diff/1/src/objects-printer.cc File src/objects-printer.cc (right): https://codereview.chromium.org/2169143003/diff/1/src/objects-printer.cc#newcode345 src/objects-printer.cc:345: os << "<the_hole>"; as discussed, this could also just ...
4 years, 4 months ago (2016-07-26 13:36:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169143003/20001
4 years, 4 months ago (2016-07-26 17:17:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 17:39:51 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ec4165742088043d8fede38db21a281e16682adb Cr-Commit-Position: refs/heads/master@{#38069}
4 years, 4 months ago (2016-07-26 17:43:41 UTC) #13
Camillo Bruni
4 years, 4 months ago (2016-07-26 18:53:12 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2181093003/ by cbruni@chromium.org.

The reason for reverting is: breaks android build due to uninitialized variable.
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20....

Powered by Google App Engine
This is Rietveld 408576698