cc/trees/property_tree_builder.cc - Issue 2169143002: cc: Make animated opacity trigger render surface creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/property_tree_builder.cc

Issue 2169143002: cc: Make animated opacity trigger render surface creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/property_tree_builder.cc

diff --git a/cc/trees/property_tree_builder.cc b/cc/trees/property_tree_builder.cc

index 6d9c2f20c70effbfdc49a256683c9e7e55980cfb..fe2276b56e21a287319de4387930cbe55fc46f6b 100644

--- a/cc/trees/property_tree_builder.cc

+++ b/cc/trees/property_tree_builder.cc

@@ -874,7 +874,9 @@ bool ShouldCreateRenderSurface(LayerType* layer,

num_descendants_that_draw_content > 0 &&

(layer->DrawsContent() || num_descendants_that_draw_content > 1);

- if (EffectiveOpacity(layer) != 1.f && ShouldFlattenTransform(layer) &&

+ bool may_have_transparency = EffectiveOpacity(layer) != 1.f ||

+ HasPotentiallyRunningOpacityAnimation(layer);

+ if (may_have_transparency && ShouldFlattenTransform(layer) &&

at_least_two_layers_in_subtree_draw_content) {

TRACE_EVENT_INSTANT0(

"cc", "PropertyTreeBuilder::ShouldCreateRenderSurface opacity",

« no previous file with comments | « cc/trees/layer_tree_host_common_unittest.cc ('k') | no next file » | no next file with comments »