Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216913002: Extract SyncLoadResponse struct from ResourceLoaderBridge. (Closed)

Created:
6 years, 9 months ago by tfarina
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, Avi (use Gerrit), jochen (gone - plz use gerrit), pilgrim_google, jamesr
Visibility:
Public.

Description

Extract SyncLoadResponse struct from ResourceLoaderBridge. And move it into content/child/sync_load_response.*. As requested by John in - https://codereview.chromium.org/186193005/diff/1/content/public/child/resource_loader_bridge.h#newcode111 BUG=265753, 338338, 237249 TEST=content_unittests R=jam@chromium.org TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260466

Patch Set 1 #

Patch Set 2 : namespace content #

Patch Set 3 : chrome fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -34 lines) Patch
M chrome/renderer/extensions/extension_localization_peer.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/security_filter_peer.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
A content/child/sync_load_response.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
A + content/child/sync_load_response.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/content_child.gypi View 1 chunk +4 lines, -2 lines 0 comments Download
M webkit/child/resource_loader_bridge.h View 2 chunks +4 lines, -19 lines 0 comments Download
M webkit/child/resource_loader_bridge.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 35 (0 generated)
tfarina
6 years, 9 months ago (2014-03-28 12:21:12 UTC) #1
jam
lgtm btw there's also WebSocketStreamHandleBridge in content that should be removed, for the same reasons ...
6 years, 9 months ago (2014-03-28 18:15:07 UTC) #2
tfarina
TBRing Darin for webkit/ changes.
6 years, 9 months ago (2014-03-29 02:17:17 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-29 02:17:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/216913002/40001
6 years, 9 months ago (2014-03-29 02:17:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 03:22:19 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290809
6 years, 9 months ago (2014-03-29 03:22:20 UTC) #7
darin (slow to review)
LGTM for src/webkit/
6 years, 9 months ago (2014-03-29 04:09:32 UTC) #8
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-03-29 14:33:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/216913002/40001
6 years, 8 months ago (2014-03-29 14:33:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 16:08:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 16:08:17 UTC) #12
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 8 months ago (2014-03-29 16:33:30 UTC) #13
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-03-29 16:33:30 UTC) #14
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 8 months ago (2014-03-29 16:33:31 UTC) #15
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-03-29 16:33:31 UTC) #16
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-03-29 16:33:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/216913002/40001
6 years, 8 months ago (2014-03-29 16:33:47 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 18:02:19 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 18:02:19 UTC) #20
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-03-29 19:25:53 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/216913002/40001
6 years, 8 months ago (2014-03-29 19:26:16 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 21:01:31 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 21:01:31 UTC) #24
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-03-29 21:46:21 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/216913002/40001
6 years, 8 months ago (2014-03-29 21:46:31 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 23:18:43 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 23:18:43 UTC) #28
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-03-30 14:18:31 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/216913002/40001
6 years, 8 months ago (2014-03-30 14:19:04 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 15:55:33 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-30 15:55:34 UTC) #32
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-03-30 18:58:03 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/216913002/40001
6 years, 8 months ago (2014-03-30 18:58:11 UTC) #34
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 20:50:18 UTC) #35
Message was sent while issue was closed. 
Change committed as 260466

Powered by Google App Engine
This is Rietveld 408576698