Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 2169103002: Revert of Check that all RenderProcessHost(s) are terminated. (Closed)

Created:
4 years, 5 months ago by alokp
Modified:
4 years, 5 months ago
Reviewers:
jam, DaleCurtis
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, henrika (OOO until Aug 14), nasko+codewatch_chromium.org, Primiano Tucci (use gerrit), tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Check that all RenderProcessHost(s) are terminated. (patchset #3 id:40001 of https://codereview.chromium.org/2133813002/ ) Reason for revert: This was temporarily added to collect data for diagnosing crbug.com/608049. We have enough data points now to study. This can now be reverted. BUG=628192 Original issue's description: > Check that all RenderProcessHost(s) are terminated. > > BUG=608049 > > Committed: https://crrev.com/3d47eced8c022d3fd666c005c7a8b3f26f8c773e > Cr-Commit-Position: refs/heads/master@{#405320} TBR=dalecurtis@chromium.org,jam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608049 Committed: https://crrev.com/3d7d415698ef069e9c0315214ca87ed11a718901 Cr-Commit-Position: refs/heads/master@{#406982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
alokp
Created Revert of Check that all RenderProcessHost(s) are terminated.
4 years, 5 months ago (2016-07-21 20:01:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169103002/1
4 years, 5 months ago (2016-07-21 20:01:58 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/99880)
4 years, 5 months ago (2016-07-21 20:16:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169103002/1
4 years, 5 months ago (2016-07-21 21:51:20 UTC) #7
jam
lgtm
4 years, 5 months ago (2016-07-21 22:36:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 22:55:55 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:57:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d7d415698ef069e9c0315214ca87ed11a718901
Cr-Commit-Position: refs/heads/master@{#406982}

Powered by Google App Engine
This is Rietveld 408576698