Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 216903004: Add optional public header checking to GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unit test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/header_checker_unittest.cc ('k') | tools/gn/secondary/testing/gmock/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer.cc
diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index ae29b4642daea181e02b1f2e67dc4e6ba7fa95f2..392bc54b84fd643d00431fb7dbefe5c9ff94e55c 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -151,8 +151,7 @@ void NinjaBinaryTargetWriter::WriteSources(
for (size_t i = 0; i < sources.size(); i++) {
const SourceFile& input_file = sources[i];
- SourceFileType input_file_type = GetSourceFileType(input_file,
- settings_->target_os());
+ SourceFileType input_file_type = GetSourceFileType(input_file);
if (input_file_type == SOURCE_UNKNOWN)
continue; // Skip unknown file types.
std::string command =
@@ -429,8 +428,7 @@ void NinjaBinaryTargetWriter::ClassifyDependency(
} else {
// Linking in a source set, copy its object files.
for (size_t i = 0; i < dep->sources().size(); i++) {
- SourceFileType input_file_type = GetSourceFileType(
- dep->sources()[i], dep->settings()->target_os());
+ SourceFileType input_file_type = GetSourceFileType(dep->sources()[i]);
if (input_file_type != SOURCE_UNKNOWN &&
input_file_type != SOURCE_H) {
// Note we need to specify the target as the source_set target
« no previous file with comments | « tools/gn/header_checker_unittest.cc ('k') | tools/gn/secondary/testing/gmock/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698