Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: tools/gn/c_include_iterator_unittest.cc

Issue 216903004: Add optional public header checking to GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unit test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/c_include_iterator.cc ('k') | tools/gn/command_check.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/c_include_iterator_unittest.cc
diff --git a/tools/gn/c_include_iterator_unittest.cc b/tools/gn/c_include_iterator_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..53d41edd65822f4cca0482dc02219375775adca9
--- /dev/null
+++ b/tools/gn/c_include_iterator_unittest.cc
@@ -0,0 +1,92 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "testing/gtest/include/gtest/gtest.h"
+#include "tools/gn/c_include_iterator.h"
+
+TEST(CIncludeIterator, Basic) {
+ std::string buffer;
+ buffer.append("// Some comment\n");
+ buffer.append("\n");
+ buffer.append("#include \"foo/bar.h\"\n");
+ buffer.append("\n");
+ buffer.append("#include <stdio.h>\n");
+ buffer.append("\n");
+ buffer.append(" #include \"foo/baz.h\"\n"); // Leading whitespace
+ buffer.append("#include \"la/deda.h\"\n");
+ buffer.append("#import \"weird_mac_import.h\"\n");
+ buffer.append("\n");
+ buffer.append("void SomeCode() {\n");
+
+ CIncludeIterator iter(buffer);
+
+ base::StringPiece contents;
+ EXPECT_TRUE(iter.GetNextIncludeString(&contents));
+ EXPECT_EQ("foo/bar.h", contents);
+ EXPECT_TRUE(iter.GetNextIncludeString(&contents));
+ EXPECT_EQ("foo/baz.h", contents);
+ EXPECT_TRUE(iter.GetNextIncludeString(&contents));
+ EXPECT_EQ("la/deda.h", contents);
+ EXPECT_TRUE(iter.GetNextIncludeString(&contents));
+ EXPECT_EQ("weird_mac_import.h", contents);
+ EXPECT_FALSE(iter.GetNextIncludeString(&contents));
+}
+
+// Tests that we don't search for includes indefinitely.
+TEST(CIncludeIterator, GiveUp) {
+ std::string buffer;
+ for (size_t i = 0; i < 1000; i++)
+ buffer.append("x\n");
+ buffer.append("#include \"foo/bar.h\"\n");
+
+ base::StringPiece contents;
+
+ CIncludeIterator iter(buffer);
+ EXPECT_FALSE(iter.GetNextIncludeString(&contents));
+ EXPECT_TRUE(contents.empty());
+}
+
+// Don't count blank lines, comments, and preprocessor when giving up.
+TEST(CIncludeIterator, DontGiveUp) {
+ std::string buffer;
+ for (size_t i = 0; i < 1000; i++)
+ buffer.push_back('\n');
+ for (size_t i = 0; i < 1000; i++)
+ buffer.append("// comment\n");
+ for (size_t i = 0; i < 1000; i++)
+ buffer.append("#preproc\n");
+ buffer.append("#include \"foo/bar.h\"\n");
+
+ base::StringPiece contents;
+
+ CIncludeIterator iter(buffer);
+ EXPECT_TRUE(iter.GetNextIncludeString(&contents));
+ EXPECT_EQ("foo/bar.h", contents);
+}
+
+// Tests that we'll tolerate some small numbers of non-includes interspersed
+// with real includes.
+TEST(CIncludeIterator, TolerateNonIncludes) {
+ const size_t kSkip = CIncludeIterator::kMaxNonIncludeLines - 2;
+ const size_t kGroupCount = 100;
+
+ std::string include("foo/bar.h");
+
+ // Allow a series of includes with blanks in between.
+ std::string buffer;
+ for (size_t group = 0; group < kGroupCount; group++) {
+ for (size_t i = 0; i < kSkip; i++)
+ buffer.append("foo\n");
+ buffer.append("#include \"" + include + "\"\n");
+ }
+
+ base::StringPiece contents;
+
+ CIncludeIterator iter(buffer);
+ for (size_t group = 0; group < kGroupCount; group++) {
+ EXPECT_TRUE(iter.GetNextIncludeString(&contents));
+ EXPECT_EQ(include, contents.as_string());
+ }
+ EXPECT_FALSE(iter.GetNextIncludeString(&contents));
+}
« no previous file with comments | « tools/gn/c_include_iterator.cc ('k') | tools/gn/command_check.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698