Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tools/gn/setup.h

Issue 216903004: Add optional public header checking to GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/setup.h
diff --git a/tools/gn/setup.h b/tools/gn/setup.h
index 8fbe3ff21be3c6b8c1792a064b1d35d22e55f09b..eb9d37b2b445288700335c0b6e3af8fdacdd1d3b 100644
--- a/tools/gn/setup.h
+++ b/tools/gn/setup.h
@@ -48,6 +48,12 @@ class CommonSetup {
check_for_unused_overrides_ = s;
}
+ // After a successful run, setting this will additionally cause the public
+ // headers to be checked. Defaults to false.
+ void set_check_public_headers(bool s) {
+ check_public_headers_ = s;
+ }
+
BuildSettings& build_settings() { return build_settings_; }
Builder* builder() { return builder_.get(); }
LoaderImpl* loader() { return loader_.get(); }
@@ -69,6 +75,7 @@ class CommonSetup {
bool check_for_bad_items_;
bool check_for_unused_overrides_;
+ bool check_public_headers_;
private:
CommonSetup& operator=(const CommonSetup& other); // Disallow.

Powered by Google App Engine
This is Rietveld 408576698