tools/gn/binary_target_generator.cc - Issue 216903004: Add optional public header checking to GN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/binary_target_generator.cc

Issue 216903004: Add optional public header checking to GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/binary_target_generator.cc

diff --git a/tools/gn/binary_target_generator.cc b/tools/gn/binary_target_generator.cc

index 3e36297ab2ef923b59dc2da2c395130a0ee3bbcd..0eba531568231ef322e94d6928d46d151def8d6f 100644

--- a/tools/gn/binary_target_generator.cc

+++ b/tools/gn/binary_target_generator.cc

@@ -37,6 +37,10 @@ void BinaryTargetGenerator::DoRun() {

if (err_->has_error())

return;

+ FillPublic();

+ if (err_->has_error())

+ return;

FillSourcePrereqs();

if (err_->has_error())

return;