Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: tools/gn/binary_target_generator.cc

Issue 216903004: Add optional public header checking to GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unit test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/c_include_iterator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/binary_target_generator.h" 5 #include "tools/gn/binary_target_generator.h"
6 6
7 #include "tools/gn/config_values_generator.h" 7 #include "tools/gn/config_values_generator.h"
8 #include "tools/gn/err.h" 8 #include "tools/gn/err.h"
9 #include "tools/gn/scope.h" 9 #include "tools/gn/scope.h"
10 #include "tools/gn/variables.h" 10 #include "tools/gn/variables.h"
(...skipping 19 matching lines...) Expand all
30 return; 30 return;
31 31
32 FillOutputExtension(); 32 FillOutputExtension();
33 if (err_->has_error()) 33 if (err_->has_error())
34 return; 34 return;
35 35
36 FillSources(); 36 FillSources();
37 if (err_->has_error()) 37 if (err_->has_error())
38 return; 38 return;
39 39
40 FillPublic();
41 if (err_->has_error())
42 return;
43
40 FillSourcePrereqs(); 44 FillSourcePrereqs();
41 if (err_->has_error()) 45 if (err_->has_error())
42 return; 46 return;
43 47
44 FillConfigs(); 48 FillConfigs();
45 if (err_->has_error()) 49 if (err_->has_error())
46 return; 50 return;
47 51
48 // Config values (compiler flags, etc.) set directly on this target. 52 // Config values (compiler flags, etc.) set directly on this target.
49 ConfigValuesGenerator gen(&target_->config_values(), scope_, 53 ConfigValuesGenerator gen(&target_->config_values(), scope_,
(...skipping 13 matching lines...) Expand all
63 } 67 }
64 68
65 void BinaryTargetGenerator::FillOutputExtension() { 69 void BinaryTargetGenerator::FillOutputExtension() {
66 const Value* value = scope_->GetValue(variables::kOutputExtension, true); 70 const Value* value = scope_->GetValue(variables::kOutputExtension, true);
67 if (!value) 71 if (!value)
68 return; 72 return;
69 if (!value->VerifyTypeIs(Value::STRING, err_)) 73 if (!value->VerifyTypeIs(Value::STRING, err_))
70 return; 74 return;
71 target_->set_output_extension(value->string_value()); 75 target_->set_output_extension(value->string_value());
72 } 76 }
OLDNEW
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/c_include_iterator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698