Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: media/capture/video/file_video_capture_device_factory.cc

Issue 2169013002: Change class VideoCaptureDevice::Name to struct VideoCaptureDeviceDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build errors Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/file_video_capture_device_factory.cc
diff --git a/media/capture/video/file_video_capture_device_factory.cc b/media/capture/video/file_video_capture_device_factory.cc
index 71fad974456197e7bd0bd7095c25c49a1e11c280..0ead703662115d63c6419c94c8af87b99629807e 100644
--- a/media/capture/video/file_video_capture_device_factory.cc
+++ b/media/capture/video/file_video_capture_device_factory.cc
@@ -25,43 +25,42 @@ base::FilePath GetFilePathFromCommandLine() {
return command_line_file_path;
}
-std::unique_ptr<VideoCaptureDevice> FileVideoCaptureDeviceFactory::Create(
- const VideoCaptureDevice::Name& device_name) {
+std::unique_ptr<VideoCaptureDevice> FileVideoCaptureDeviceFactory::CreateDevice(
+ const VideoCaptureDeviceDescriptor& device_descriptor) {
DCHECK(thread_checker_.CalledOnValidThread());
#if defined(OS_WIN)
return std::unique_ptr<VideoCaptureDevice>(new FileVideoCaptureDevice(
- base::FilePath(base::SysUTF8ToWide(device_name.name()))));
+ base::FilePath(base::SysUTF8ToWide(device_descriptor.display_name))));
#else
- return std::unique_ptr<VideoCaptureDevice>(
- new FileVideoCaptureDevice(base::FilePath(device_name.name())));
+ return std::unique_ptr<VideoCaptureDevice>(new FileVideoCaptureDevice(
+ base::FilePath(device_descriptor.display_name)));
#endif
}
-void FileVideoCaptureDeviceFactory::GetDeviceNames(
- VideoCaptureDevice::Names* const device_names) {
+void FileVideoCaptureDeviceFactory::GetDeviceDescriptors(
+ VideoCaptureDeviceDescriptors* device_descriptors) {
DCHECK(thread_checker_.CalledOnValidThread());
- DCHECK(device_names->empty());
+ DCHECK(device_descriptors->empty());
const base::FilePath command_line_file_path = GetFilePathFromCommandLine();
+ device_descriptors->emplace_back(
#if defined(OS_WIN)
- device_names->push_back(VideoCaptureDevice::Name(
base::SysWideToUTF8(command_line_file_path.value()),
- kFileVideoCaptureDeviceName, VideoCaptureDevice::Name::DIRECT_SHOW));
+ kFileVideoCaptureDeviceName, VideoCaptureApi::WIN_DIRECT_SHOW
#elif defined(OS_MACOSX)
- device_names->push_back(VideoCaptureDevice::Name(
command_line_file_path.value(), kFileVideoCaptureDeviceName,
- VideoCaptureDevice::Name::AVFOUNDATION));
+ VideoCaptureApi::MACOSX_AVFOUNDATION
#elif defined(OS_LINUX)
- device_names->push_back(VideoCaptureDevice::Name(
command_line_file_path.value(), kFileVideoCaptureDeviceName,
- VideoCaptureDevice::Name::V4L2_SINGLE_PLANE));
+ VideoCaptureApi::LINUX_V4L2_SINGLE_PLANE
#else
- device_names->push_back(VideoCaptureDevice::Name(
- command_line_file_path.value(), kFileVideoCaptureDeviceName));
+ command_line_file_path.value(), kFileVideoCaptureDeviceName,
+ VideoCaptureApi::UNKNOWN
#endif
+ );
}
-void FileVideoCaptureDeviceFactory::GetDeviceSupportedFormats(
- const VideoCaptureDevice::Name& device,
+void FileVideoCaptureDeviceFactory::GetSupportedFormats(
+ const VideoCaptureDeviceDescriptor& device_descriptor,
VideoCaptureFormats* supported_formats) {
DCHECK(thread_checker_.CalledOnValidThread());
« no previous file with comments | « media/capture/video/file_video_capture_device_factory.h ('k') | media/capture/video/linux/v4l2_capture_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698