Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: content/browser/media/media_internals.cc

Issue 2169013002: Change class VideoCaptureDevice::Name to struct VideoCaptureDeviceDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build errors Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/media_internals.h ('k') | content/browser/media/media_internals_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/media_internals.cc
diff --git a/content/browser/media/media_internals.cc b/content/browser/media/media_internals.cc
index 33df1a834fc3b6d18f9947b8372a5f26e900e05b..3ef867386b38ba2c1d3df7d8e3b1e29f5092261b 100644
--- a/content/browser/media/media_internals.cc
+++ b/content/browser/media/media_internals.cc
@@ -600,29 +600,33 @@ void MediaInternals::SendVideoCaptureDeviceCapabilities() {
}
void MediaInternals::UpdateVideoCaptureDeviceCapabilities(
- const media::VideoCaptureDeviceInfos& video_capture_device_infos) {
+ const std::vector<std::tuple<media::VideoCaptureDeviceDescriptor,
+ media::VideoCaptureFormats>>&
+ descriptors_and_formats) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
video_capture_capabilities_cached_data_.Clear();
- for (const auto& video_capture_device_info : video_capture_device_infos) {
+ for (const auto& device_format_pair : descriptors_and_formats) {
base::ListValue* format_list = new base::ListValue();
// TODO(nisse): Representing format information as a string, to be
// parsed by the javascript handler, is brittle. Consider passing
// a list of mappings instead.
- for (const auto& format : video_capture_device_info.supported_formats)
+ const media::VideoCaptureDeviceDescriptor& descriptor =
+ std::get<0>(device_format_pair);
+ const media::VideoCaptureFormats& supported_formats =
+ std::get<1>(device_format_pair);
+ for (const auto& format : supported_formats)
format_list->AppendString(media::VideoCaptureFormat::ToString(format));
std::unique_ptr<base::DictionaryValue> device_dict(
new base::DictionaryValue());
- device_dict->SetString("id", video_capture_device_info.name.id());
- device_dict->SetString(
- "name", video_capture_device_info.name.GetNameAndModel());
+ device_dict->SetString("id", descriptor.device_id);
+ device_dict->SetString("name", descriptor.GetNameAndModel());
device_dict->Set("formats", format_list);
#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX) || \
defined(OS_ANDROID)
- device_dict->SetString(
- "captureApi", video_capture_device_info.name.GetCaptureApiTypeString());
+ device_dict->SetString("captureApi", descriptor.GetCaptureApiTypeString());
#endif
video_capture_capabilities_cached_data_.Append(std::move(device_dict));
}
« no previous file with comments | « content/browser/media/media_internals.h ('k') | content/browser/media/media_internals_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698