Change class VideoCaptureDevice::Name to struct VideoCaptureDeviceDescriptor

content/browser/media/video_capture_device_info.h

Index: content/browser/media/video_capture_device_info.h
diff --git a/content/browser/media/video_capture_device_info.h b/content/browser/media/video_capture_device_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..6e86e8f9bf7498e45102d3b56b34c6cb3b0fcaf5
--- /dev/null
+++ b/content/browser/media/video_capture_device_info.h
@@ -0,0 +1,31 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_MEDIA_VIDEO_CAPTURE_DEVICE_INFO_H_
+#define CONTENT_BROWSER_MEDIA_VIDEO_CAPTURE_DEVICE_INFO_H_
+
+#include "content/common/content_export.h"
+#include "media/base/video_capture_types.h"
+#include "media/capture/video/video_capture_device_descriptor.h"
+
+namespace content {
+
+// Bundles a media::VideoCaptureDeviceDescriptor with corresponding supported
+// video formats.
+struct CONTENT_EXPORT VideoCaptureDeviceInfo {

[mcasas, 2016/07/30 00:06:11]

Last proposal:
- Move this class as internal to VideoCaptureManager, i.e.
 forward declare in the .h file and implement in the .cc

- The only other use of this class is in [1]:
MediaInternals::UpdateVideoCaptureDeviceCapabilities()
but IMHO is not worth creating this extra public class just
for that use, that eventually might be removed anyhow (was
intended to be a debug feature...); instead, I propose changing
that method's signature to sth like

  void UpdateVideoCaptureDeviceCapabilities(
      const std::vector<std::tuple<media:VideoCaptureDeviceDescriptor,
      media::VideoCaptureFormats>>& devices_and_formats);        

and composing this vector in l.927's for loop below [2], WDYT?


[1]
https://cs.chromium.org/chromium/src/content/browser/media/media_internals.h?...
[2]
https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/vide...

[chfremer, 2016/08/01 18:53:12]

Done.

Even though I think that nested classes/structs are a bad idea in general, this
approach seems consistent with the rest of the Chromium code base.

The other downside is the extra copying that has to happen to package the stuff
into the tuple type ad-hoc.

+  VideoCaptureDeviceInfo();
+  VideoCaptureDeviceInfo(media::VideoCaptureDeviceDescriptor descriptor);
+  ~VideoCaptureDeviceInfo();
+  VideoCaptureDeviceInfo(const VideoCaptureDeviceInfo& other);
+  VideoCaptureDeviceInfo& operator=(const VideoCaptureDeviceInfo& other);
+
+  media::VideoCaptureDeviceDescriptor descriptor;
+  media::VideoCaptureFormats supported_formats;
+};
+
+using VideoCaptureDeviceInfos = std::vector<VideoCaptureDeviceInfo>;
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_MEDIA_VIDEO_CAPTURE_DEVICE_INFO_H_