Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: media/capture/video/video_capture_device_factory.cc

Issue 2169013002: Change class VideoCaptureDevice::Name to struct VideoCaptureDeviceDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed emircan's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/video_capture_device_factory.cc
diff --git a/media/capture/video/video_capture_device_factory.cc b/media/capture/video/video_capture_device_factory.cc
index 39aa62aba6fa0d0eda0c4511f781cd3ab754e3a4..e32103a1a01267436087b7685fd157e69bd6b5b9 100644
--- a/media/capture/video/video_capture_device_factory.cc
+++ b/media/capture/video/video_capture_device_factory.cc
@@ -45,15 +45,15 @@ VideoCaptureDeviceFactory::VideoCaptureDeviceFactory() {
VideoCaptureDeviceFactory::~VideoCaptureDeviceFactory() {
mcasas 2016/07/26 23:52:04 nit: I might be wrong, but I believe empty functio
chfremer 2016/07/27 23:10:18 Done.
}
-void VideoCaptureDeviceFactory::EnumerateDeviceNames(
- const base::Callback<
- void(std::unique_ptr<media::VideoCaptureDevice::Names>)>& callback) {
+void VideoCaptureDeviceFactory::EnumerateDeviceDescriptors(
+ const base::Callback<void(std::unique_ptr<VideoCaptureDeviceDescriptors>)>&
+ callback) {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(!callback.is_null());
- std::unique_ptr<VideoCaptureDevice::Names> device_names(
- new VideoCaptureDevice::Names());
- GetDeviceNames(device_names.get());
- callback.Run(std::move(device_names));
+ std::unique_ptr<VideoCaptureDeviceDescriptors> device_descriptors(
+ new VideoCaptureDeviceDescriptors());
+ GetDeviceDescriptors(device_descriptors.get());
+ callback.Run(std::move(device_descriptors));
}
#if !defined(OS_MACOSX) && !defined(OS_LINUX) && !defined(OS_ANDROID) && \

Powered by Google App Engine
This is Rietveld 408576698