content/browser/media/video_capture_device_info.cc - Issue 2169013002: Change class VideoCaptureDevice::Name to struct VideoCaptureDeviceDescriptor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/media/video_capture_device_info.cc

Issue 2169013002: Change class VideoCaptureDevice::Name to struct VideoCaptureDeviceDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed emircan's comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/media/video_capture_device_info.h ('K') | « content/browser/media/video_capture_device_info.h ('k') | content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc » ('j') | media/capture/video/android/video_capture_device_factory_android.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/browser/media/video_capture_device_info.h"

	6

	7 namespace content {

	8

	9 VideoCaptureDeviceInfo::VideoCaptureDeviceInfo() {}
	mcasas 2016/07/30 00:06:11 nit: you can also add =default in the declaration, nit: you can also add =default in the declaration, and spare these two lines. chfremer 2016/08/01 18:53:12 Done. Show quoted text On 2016/07/30 00:06:11, mcasas wrote: > nit: you can also add =default in the > declaration, and spare these two lines. Done.
	10

	11 VideoCaptureDeviceInfo::VideoCaptureDeviceInfo(

	12 media::VideoCaptureDeviceDescriptor descriptor)

	13 : descriptor(descriptor) {}

	14

	15 VideoCaptureDeviceInfo::~VideoCaptureDeviceInfo() = default;

	16 VideoCaptureDeviceInfo::VideoCaptureDeviceInfo(

	17 const VideoCaptureDeviceInfo& other) = default;

	18 VideoCaptureDeviceInfo& VideoCaptureDeviceInfo::operator=(

	19 const VideoCaptureDeviceInfo& other) = default;

	20

	21 } // namespace content

OLD	NEW