Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: media/capture/video/fake_video_capture_device_factory.cc

Issue 2169013002: Change class VideoCaptureDevice::Name to struct VideoCaptureDeviceDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactoring of VideoCaptureDeviceFactory interface Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/capture/video/fake_video_capture_device_factory.h" 5 #include "media/capture/video/fake_video_capture_device_factory.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/string_split.h" 9 #include "base/strings/string_split.h"
10 #include "base/strings/string_tokenizer.h" 10 #include "base/strings/string_tokenizer.h"
11 #include "base/strings/string_util.h" 11 #include "base/strings/string_util.h"
12 #include "base/strings/stringprintf.h" 12 #include "base/strings/stringprintf.h"
13 #include "build/build_config.h" 13 #include "build/build_config.h"
14 #include "media/base/media_switches.h" 14 #include "media/base/media_switches.h"
15 15
16 namespace media { 16 namespace media {
17 17
18 // Cap the frame rate command line input to reasonable values. 18 // Cap the frame rate command line input to reasonable values.
19 static const float kFakeCaptureMinFrameRate = 5.0f; 19 static const float kFakeCaptureMinFrameRate = 5.0f;
20 static const float kFakeCaptureMaxFrameRate = 60.0f; 20 static const float kFakeCaptureMaxFrameRate = 60.0f;
21 // Default rate if none is specified as part of the command line. 21 // Default rate if none is specified as part of the command line.
22 static const float kFakeCaptureDefaultFrameRate = 20.0f; 22 static const float kFakeCaptureDefaultFrameRate = 20.0f;
23 23
24 FakeVideoCaptureDeviceFactory::FakeVideoCaptureDeviceFactory() 24 FakeVideoCaptureDeviceFactory::FakeVideoCaptureDeviceFactory()
25 : number_of_devices_(1), 25 : number_of_devices_(1),
26 fake_vcd_ownership_(FakeVideoCaptureDevice::BufferOwnership::OWN_BUFFERS), 26 fake_vcd_ownership_(FakeVideoCaptureDevice::BufferOwnership::OWN_BUFFERS),
27 frame_rate_(kFakeCaptureDefaultFrameRate) {} 27 frame_rate_(kFakeCaptureDefaultFrameRate) {}
28 28
29 std::unique_ptr<VideoCaptureDevice> FakeVideoCaptureDeviceFactory::Create( 29 std::unique_ptr<VideoCaptureDevice> FakeVideoCaptureDeviceFactory::Create(
30 const VideoCaptureDevice::Name& device_name) { 30 const VideoCaptureDeviceDescriptor& device_descriptor) {
31 DCHECK(thread_checker_.CalledOnValidThread()); 31 DCHECK(thread_checker_.CalledOnValidThread());
32 32
33 parse_command_line(); 33 parse_command_line();
34 34
35 for (int n = 0; n < number_of_devices_; ++n) { 35 for (int n = 0; n < number_of_devices_; ++n) {
36 std::string possible_id = base::StringPrintf("/dev/video%d", n); 36 std::string possible_id = base::StringPrintf("/dev/video%d", n);
37 if (device_name.id().compare(possible_id) == 0) { 37 if (device_descriptor.device_id.compare(possible_id) == 0) {
38 return std::unique_ptr<VideoCaptureDevice>( 38 return std::unique_ptr<VideoCaptureDevice>(
39 new FakeVideoCaptureDevice(fake_vcd_ownership_, frame_rate_)); 39 new FakeVideoCaptureDevice(fake_vcd_ownership_, frame_rate_));
40 } 40 }
41 } 41 }
42 return std::unique_ptr<VideoCaptureDevice>(); 42 return std::unique_ptr<VideoCaptureDevice>();
43 } 43 }
44 44
45 void FakeVideoCaptureDeviceFactory::GetDeviceNames( 45 void FakeVideoCaptureDeviceFactory::GetDeviceDescriptors(
46 VideoCaptureDevice::Names* const device_names) { 46 VideoCaptureDeviceDescriptors* device_descriptors) {
47 DCHECK(thread_checker_.CalledOnValidThread()); 47 DCHECK(thread_checker_.CalledOnValidThread());
48 DCHECK(device_names->empty()); 48 DCHECK(device_descriptors->empty());
49 for (int n = 0; n < number_of_devices_; ++n) { 49 for (int n = 0; n < number_of_devices_; ++n) {
50 VideoCaptureDevice::Name name(base::StringPrintf("fake_device_%d", n), 50 VideoCaptureDeviceDescriptor descriptor;
51 base::StringPrintf("/dev/video%d", n) 51 descriptor.device_id = base::StringPrintf("/dev/video%d", n);
52 descriptor.friendly_name = base::StringPrintf("fake_device_%d", n);
52 #if defined(OS_LINUX) 53 #if defined(OS_LINUX)
53 , 54 descriptor.capture_api = VideoCaptureApiType::LINUX_V4L2_SINGLE_PLANE;
54 VideoCaptureDevice::Name::V4L2_SINGLE_PLANE
55 #elif defined(OS_MACOSX) 55 #elif defined(OS_MACOSX)
56 , 56 descriptor.capture_api = VideoCaptureApiType::MACOSX_AVFOUNDATION;
57 VideoCaptureDevice::Name::AVFOUNDATION
58 #elif defined(OS_WIN) 57 #elif defined(OS_WIN)
59 , 58 descriptor.capture_api = VideoCaptureApiType::WINDOWS_DIRECT_SHOW;
60 VideoCaptureDevice::Name::DIRECT_SHOW
61 #elif defined(OS_ANDROID) 59 #elif defined(OS_ANDROID)
62 , 60 descriptor.capture_api = VideoCaptureApiType::ANDROID_API2_LEGACY;
63 VideoCaptureDevice::Name::API2_LEGACY
64 #endif 61 #endif
65 ); 62 device_descriptors->push_back(descriptor);
66 device_names->push_back(name);
67 } 63 }
68 } 64 }
69 65
66 void FakeVideoCaptureDeviceFactory::GetDeviceInfo(
67 const VideoCaptureDeviceDescriptor& device_descriptor,
68 VideoCaptureDeviceInfo* device_info) {
69 DCHECK(device_info);
70 device_info->descriptor = device_descriptor;
71 GetDeviceSupportedFormats(device_descriptor,
72 &(device_info->supported_formats));
73 }
74
70 void FakeVideoCaptureDeviceFactory::GetDeviceSupportedFormats( 75 void FakeVideoCaptureDeviceFactory::GetDeviceSupportedFormats(
71 const VideoCaptureDevice::Name& device, 76 const VideoCaptureDeviceDescriptor& device_descriptor,
72 VideoCaptureFormats* supported_formats) { 77 VideoCaptureFormats* supported_formats) {
73 DCHECK(thread_checker_.CalledOnValidThread()); 78 DCHECK(thread_checker_.CalledOnValidThread());
74 const gfx::Size supported_sizes[] = {gfx::Size(320, 240), 79 const gfx::Size supported_sizes[] = {gfx::Size(320, 240),
75 gfx::Size(640, 480), 80 gfx::Size(640, 480),
76 gfx::Size(1280, 720), 81 gfx::Size(1280, 720),
77 gfx::Size(1920, 1080)}; 82 gfx::Size(1920, 1080)};
78 supported_formats->clear(); 83 supported_formats->clear();
79 for (const auto& size : supported_sizes) { 84 for (const auto& size : supported_sizes) {
80 supported_formats->push_back( 85 supported_formats->push_back(
81 VideoCaptureFormat(size, frame_rate_, media::PIXEL_FORMAT_I420)); 86 VideoCaptureFormat(size, frame_rate_, media::PIXEL_FORMAT_I420));
(...skipping 30 matching lines...) Expand all
112 if (base::StringToDouble(param.back(), &fps)) { 117 if (base::StringToDouble(param.back(), &fps)) {
113 frame_rate_ = 118 frame_rate_ =
114 std::max(kFakeCaptureMinFrameRate, static_cast<float>(fps)); 119 std::max(kFakeCaptureMinFrameRate, static_cast<float>(fps));
115 frame_rate_ = std::min(kFakeCaptureMaxFrameRate, frame_rate_); 120 frame_rate_ = std::min(kFakeCaptureMaxFrameRate, frame_rate_);
116 } 121 }
117 } 122 }
118 } 123 }
119 } 124 }
120 125
121 } // namespace media 126 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698